Refactor port logic in healthcheck and tests Suite #14736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Oct 19, 2016
| protected def fetchResults(testPort: Int, healthChecks: SingleHealthCheck*): Future[Seq[HealthCheckResult]] = { | ||
| val defaultPort = 9000 | ||
| val port = { | ||
| Play.current.mode match { |
TBonnin
force-pushed
the
tbonnin-remove-play-current-healthcheck
branch
from
51c730b
to
4004713
Compare
jfsoul
reviewed
Oct 19, 2016
| @@ -14,7 +15,9 @@ import org.scalatest.concurrent.ScalaFutures | |||
| with WithTestWsClient { | |||
|
|
|||
| "CDN health check" should "mimic the instance health check" in { | |||
| val controller = new HealthCheck(wsClient) | |||
| val testPort: Int = port | |||
There was a problem hiding this comment.
This is just for clarity or is it needed for the override to compile?
There was a problem hiding this comment.
Necessary, otherwise the port val in the constructor closure shadows the test port
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
My original goal was to get rid of the
Play.currentreference into theHealthCheckcode.However I thought it would be a good time to refactor this weird logic where a port is specify to the Healthcheck, which is then used to override the OneServerPerSuite port so multiple suite don't overlap on the same port and the healthcheck is aware of this port on which it needs to run its internal check.
So now:
SuiteWhat is the value of this and can you measure success?
Request for comment
@alexduf @jfsoul