Prepare for dated newspaper page requests #11150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,26 @@ | |||
| @(index: services.IndexPage, nav: PreviousAndNext)(implicit request: RequestHeader) | |||
There was a problem hiding this comment.
This view isn't used so can be removed?
There was a problem hiding this comment.
Ah yes, thanks. That was left over from the earliest days of this thing's existence. Should have been binned a while back. Will do that now.
Conflicts: article/app/controllers/ArticleController.scala
|
|
||
| } | ||
|
|
||
| private def tagExists(publication: String, tag: String) = { |
There was a problem hiding this comment.
might be worth renaming to bookSectionTagExists
There was a problem hiding this comment.
Fair point. Will do.
|
👍 |
JustinPinner
added a commit
that referenced
this pull request
Nov 24, 2015
Prepare for dated newspaper page requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling of newspaper book and book section requests so that we no longer have to hand these off to R2.
Tests are misbehaving locally, so I'm using the PR to trigger a server-side build and test 😎