Skip to content

Commit

Permalink
adding condition that you must be on a gallery as well as in the test…
Browse files Browse the repository at this point in the history
… for slimheader
  • Loading branch information
NataliaLKB committed Apr 20, 2016
1 parent f993987 commit fa60873
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions common/app/views/fragments/header.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
@fragments.newHeader()
} else {
<header id="header"
class="l-header u-cf @if(page.metadata.hasSlimHeader) {l-header--is-slim l-header--no-navigation} @if(mvt.ABGalleryRedesignVariant.isParticipating){l-header--is-slim l-header--no-navigation l-header--new-gallery} js-header"
class="l-header u-cf @if(page.metadata.hasSlimHeader) {l-header--is-slim l-header--no-navigation} @if(mvt.ABGalleryRedesignVariant.isParticipating && page.metadata.contentType.toLowerCase == "gallery"){l-header--is-slim l-header--no-navigation l-header--new-gallery} js-header"
role="banner"
data-link-name="global navigation: header">
<div class="js-navigation-header navigation-container navigation-container--collapsed">
Expand Down Expand Up @@ -105,7 +105,7 @@
} else {
<a href="@LinkTo{/}" data-link-name="site logo" id="logo" class="logo-wrapper" data-component="logo">
<span class="u-h">The Guardian</span>
@if(page.metadata.hasSlimHeader || mvt.ABGalleryRedesignVariant.isParticipating) {
@if(page.metadata.hasSlimHeader || (mvt.ABGalleryRedesignVariant.isParticipating && page.metadata.contentType.toLowerCase == "gallery")) {
@* CRAZY HACK TO FIX IE8 RENDERING ISSUE WITH LOGO SVG MARKUP *@
<!--[if (gt IE 8)|(IEMobile)]><!-->
@fragments.inlineSvg("guardian-logo-160", "logo")
Expand All @@ -128,7 +128,7 @@
}
</a>
}
@if(page.metadata.hasSlimHeader || mvt.ABGalleryRedesignVariant.isParticipating) {
@if(page.metadata.hasSlimHeader || (mvt.ABGalleryRedesignVariant.isParticipating && page.metadata.contentType.toLowerCase == "gallery")) {
@fragments.nav.navigationToggle()
}
</div>
Expand Down
3 changes: 2 additions & 1 deletion common/app/views/fragments/nav/navigation.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
@fragments.nav.topNavigation(page, navigation)
</nav>
</div>
@if(!page.metadata.hasSlimHeader && !mvt.ABGalleryRedesignVariant.isParticipating) {
@* Don't show navigation toggle if slimHeader, or participating in the gallery redesign test*@
@if(!page.metadata.hasSlimHeader && (!(mvt.ABGalleryRedesignVariant.isParticipating && page.metadata.contentType.toLowerCase == "gallery"))) {
@fragments.nav.navigationToggle()
}
</div>
Expand Down

0 comments on commit fa60873

Please sign in to comment.