Skip to content

Commit

Permalink
Remove portNumber override from test suites that implement SingleServ…
Browse files Browse the repository at this point in the history
…erSuite

Co-authored-by: Olly Namey <olly.namey@guardian.co.uk>
Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>
  • Loading branch information
3 people committed May 3, 2022
1 parent 40319a8 commit 71e7b4b
Show file tree
Hide file tree
Showing 10 changed files with 10 additions and 43 deletions.
6 changes: 1 addition & 5 deletions admin/test/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,4 @@ class AdminTestSuite
new pagepresser.InteractiveHtmlCleanerTest,
new controllers.admin.DeploysControllerTest,
)
with SingleServerSuite {

override implicit lazy val portNumber: PortNumber = PortNumber(19015)

}
with SingleServerSuite {}
6 changes: 1 addition & 5 deletions applications/test/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,4 @@ class ApplicationsTestSuite
new FacebookGraphApiTest,
new InteractivePickerTest,
)
with SingleServerSuite {

// override implicit lazy val portNumber: PortNumber = PortNumber(19003)

}
with SingleServerSuite {}
4 changes: 1 addition & 3 deletions archive/test/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,4 @@ class ArchiveTestSuite
extends Suites(
new ArchiveControllerTest,
)
with SingleServerSuite {
override implicit lazy val portNumber: PortNumber = PortNumber(19004)
}
with SingleServerSuite {}
6 changes: 1 addition & 5 deletions article/test/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,4 @@ class ArticleTestSuite
new LiveBlogControllerTest,
new ArticlePickerTest,
)
with SingleServerSuite {

// override implicit lazy val portNumber: PortNumber = PortNumber(19005)

}
with SingleServerSuite {}
5 changes: 1 addition & 4 deletions commercial/test/test/CommercialTestSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,4 @@ class CommercialTestSuite
new LookupTest,
new books.BookTest,
)
with SingleServerSuite {
override implicit lazy val portNumber: PortNumber = PortNumber(19006)

}
with SingleServerSuite {}
6 changes: 1 addition & 5 deletions common/test/CommonTestSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,4 @@ class CommonTestSuite
new FlagshipFrontContainerSpec,
new DotcomRenderingServiceTest,
)
with SingleServerSuite {

override implicit lazy val portNumber: PortNumber = PortNumber(19016)

}
with SingleServerSuite {}
5 changes: 1 addition & 4 deletions discussion/test/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,4 @@ class DiscussionTestSuite
new CommentCountControllerTest,
new ProfileTest,
)
with SingleServerSuite {
override implicit lazy val portNumber: PortNumber = PortNumber(19008)

}
with SingleServerSuite {}
4 changes: 1 addition & 3 deletions facia/test/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,4 @@ class FaciaTestSuite
new FaciaControllerTest,
new metadata.FaciaMetaDataTest,
)
with SingleServerSuite {
override implicit lazy val portNumber: PortNumber = PortNumber(19009)
}
with SingleServerSuite {}
5 changes: 1 addition & 4 deletions identity/test/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,7 @@ class IdentityTestSuite
new StrictTransportSecurityHeaderFilterTest,
new ConsentsJourneyControllerTest,
)
with SingleServerSuite {
override implicit lazy val portNumber: PortNumber = PortNumber(19010)

}
with SingleServerSuite {}

trait WithTestIdConfig {
class IdentityConfigurationStub extends IdConfig {
Expand Down
6 changes: 1 addition & 5 deletions onward/test/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,4 @@ class OnwardTestSuite
new RichLinkControllerTest,
new NavigationControllerTest,
)
with SingleServerSuite {

// override implicit lazy val portNumber: PortNumber = PortNumber(19011)

}
with SingleServerSuite {}

0 comments on commit 71e7b4b

Please sign in to comment.