Skip to content

Commit

Permalink
Convert define-slot to Typescript (#25149)
Browse files Browse the repository at this point in the history
* Convert define-slot to TypeScript

Co-authored-by: Jake Lee Kennedy <jlkennedy127@gmail.com>
Co-authored-by: Zeke Hunter-Green <zeke.huntergreen@guardian.co.uk>

* Convert define-slot to Typescript

Co-authored-by: Ravi Lal <arelra@users.noreply.github.com>
Co-authored-by: Dominik Lander <dominik.lander@guardian.co.uk>
Co-authored-by: Zeke Hunter-Green <zeke.huntergreen@guardian.co.uk>

* simplify and describe getSizeOpts

* unused export in Advert.ts

* better name for ias slot targeting

* improve function naming, docs and tests for define-slot

* use viewport sizes from source

* rebuild commercial bundle graph

* mock adSize in different test

* improve desc of collectSizes

Co-authored-by: Ravi Lal <arelra@users.noreply.github.com>
Co-authored-by: Zeke Hunter-Green <zeke.huntergreen@guardian.co.uk>
Co-authored-by: Dominik Lander <dominik.lander@guardian.co.uk>
  • Loading branch information
4 people authored Jun 30, 2022
1 parent 6286ee6 commit 555fc4c
Show file tree
Hide file tree
Showing 9 changed files with 480 additions and 307 deletions.
222 changes: 0 additions & 222 deletions static/src/javascripts/projects/commercial/modules/dfp/define-slot.js

This file was deleted.

This file was deleted.

Loading

0 comments on commit 555fc4c

Please sign in to comment.