Skip to content

Commit

Permalink
feat(Lightbox): enabled for all (#26847)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxdvl authored Jan 29, 2024
1 parent 5f45cd0 commit 456ae88
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 10 additions & 0 deletions common/app/conf/switches/JournalismSwitches.scala
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,14 @@ trait JournalismSwitches {
sellByDate = never,
exposeClientSide = false,
)

val Lightbox = Switch(
SwitchGroup.Journalism,
name = "lightbox",
description = "Enable lightbox for images",
owners = Seq(Owner.withEmail("dotcom.platform@theguardian.com")),
safeState = On,
sellByDate = never,
exposeClientSide = true,
)
}
10 changes: 0 additions & 10 deletions common/app/experiments/Experiments.scala
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import java.time.LocalDate
object ActiveExperiments extends ExperimentsDefinition {
override val allExperiments: Set[Experiment] =
Set(
Lightbox,
AdaptiveSite,
DeeplyRead,
)
Expand All @@ -27,15 +26,6 @@ object DeeplyRead
participationGroup = Perc50,
)

object Lightbox
extends Experiment(
name = "lightbox",
description = "Testing the impact lightbox might have on our CWVs",
owners = Seq(Owner.withEmail("dotcom.platform@theguardian.com")),
sellByDate = LocalDate.of(2024, 1, 31),
participationGroup = Perc5A,
)

// Removing while we are still implementing this content type in DCR
//object DCRImageContent
// extends Experiment(
Expand Down

0 comments on commit 456ae88

Please sign in to comment.