Update both CAPI & FAPI client versions to stay binary-compatible #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
rtyley
changed the title
Note that guardian/content-api-scala-client#359 broke compilation of the `CapiQueryGenerator` class in `facia-tool`, so guardian/content-api-scala-client#363 was be necessary to get compilation to pass. Use guardian/content-api-scala-client#363
rtyley
force-pushed
the
upgrade-clients-to-capi-v19-and-fapi-v4
branch
from
b4dabb6
to
f3fb9ae
Compare
jonathonherbert
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the CAPI client (v19) includes guardian/content-api-scala-client#359, which is binary-incompatible with previous versions of the CAPI client. This means we also need to update the FAPI client at the same time, as it uses the CAPI client - otherwise we would see a
java.lang.NoSuchMethodErrorexception occurring when the FAPI client calls the CAPI client.Note that guardian/content-api-scala-client#359 broke compilation of the
CapiQueryGeneratorclass infacia-tool, so guardian/content-api-scala-client#363 (released as v19.0.3) is necessary to get compilation to pass.@jonathonherbert was kind enough to double-check that the existing tests exercise the FAPI client, and also check for regressions in the CODE environment. I've deployed the final commit version to CODE, and that also looks good:
https://fronts.code.dev-gutools.co.uk/v2/issues/03a22dc5-18a2-4cbb-8733-50a07e2c5950