Update default collection type #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georges-GNM
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Yeah, wonder what happened? Looks like it may have previously been a valid container type (at least looking at the list of containers in the config when this was originally written), but clearly isn't a thing now... And we probably do want the DefaultCollectionType to be a valid collection!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Swaps "fixed/small/slow-VI" for "fixed/small/slow-IV"
Why
The container type "fixed/small/slow-VI" does not exist, so it looks like this might be a mistake. MAPI updated the equivalent logic in 2017: https://github.com/guardian/mobile-apps-api/pull/1038
Though, I'm not even sure this is ever used! The git blame says this was last updated about 10 years ago 😵 (#31)