Update to version of sbt that supports M1 hardware #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need to be able to compile this project on M1 hardware sooner or later! This PR also updates the Scala language versions to the latest maintenance releases.
jonathonherbert
approved these changes
Jun 22, 2022
|
Just to let you know I made a release to Maven Central to check that the release process still worked fine after these changes, seemed to be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need to be able to compile this project on M1 hardware sooner or later!
This PR also updates the Scala language versions to the latest maintenance releases.
I've checked, and the tests run fine locally (note there's no CI set on this project, probably because the tests require
cmsFronts-s3-readAWS Credentials to pass.See also https://github.com/guardian/ophan/pull/4383