Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): AWS dependency updates #20

Merged
merged 1 commit into from
Dec 5, 2023
Merged

chore(deps): AWS dependency updates #20

merged 1 commit into from
Dec 5, 2023

Conversation

gu-scala-steward-public-repos[bot]
Copy link
Contributor

About this PR

Updates:

  • 📦 software.amazon.awssdk:s3 from 2.20.162 to 2.21.17

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add these to your .scala-steward.conf file to ignore future updates of these dependencies:

updates.ignore = [
  { groupId = "software.amazon.awssdk", artifactId = "s3" }
]

Or, add these to slow down future updates of these dependencies:

dependencyOverrides = [
  {
    pullRequests = { frequency = "30 days" },
    dependency = { groupId = "software.amazon.awssdk", artifactId = "s3" }
  }
]
labels: dependencies, library-update, early-semver-minor, semver-spec-minor, commit-count:1

@rtyley
Copy link
Member

rtyley commented Dec 5, 2023

@julienrf it's interesting that this PR (updating a dependency with a 'minor' version bump 2.20.162 → 2.21.17) led to a 'major' version bump for etag-caching (v1.0.38 → v2.0.0). Does that make sense - what's the logic?

@julienrf
Copy link

julienrf commented Dec 5, 2023

I am not sure, to be honest. I will investigate.

The default behavior should be to assume semver by default for Java libraries:

https://github.com/scalacenter/sbt-version-policy/blob/9da7aaccc0b10fcd65575b8bf3db0b042f6b120f/sbt-version-policy/src/main/scala/sbtversionpolicy/SbtVersionPolicySettings.scala#L38-L45

@julienrf
Copy link

julienrf commented Dec 5, 2023

I just ran versionPolicyCollectCompatibilityReport on a simple project that reproduces this dependency update and discovered that the issue is caused by transitive dependencies on io.netty::netty-*, which use non-standard revisions (e.g. 4.1.100.Final), that sbt-version-policy does not know how to interpret.

The solution is to add a custom version extractor:

ThisBuild / versionPolicyModuleVersionExtractor := {
  case m if m.organization == "io.netty" && m.name.startsWith("netty-") => m.revision.stripSuffix(".Final")
}

(You should have a look at the versioning scheme of the netty artifacts to make sure your extractor is correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants