Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reject All GDPR #2423

Merged
merged 2 commits into from
Apr 26, 2024
Merged

feat: Reject All GDPR #2423

merged 2 commits into from
Apr 26, 2024

Conversation

jimhunty
Copy link
Contributor

Why are you doing this?

"Reject all" is a requested feature, that allows you to easily reject all GDPR options.

Changes

  • Removed unused getters and setters from the use-gdpr hook
  • Added a Spacer component utility
  • Added a way to modify all settings, and changed continue into a helper method, whilst alos adding reject to do the same
  • Added the reject all button to the GDPR consent content
  • Removed the text passthrough on GDPR constent content, and passed in a withContinue boolean to manage to text and functionality
  • Removed the text from the component and added it to the language file.

Screenshots

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-04-26.at.08.15.15.mp4

@jimhunty jimhunty requested a review from a team as a code owner April 26, 2024 07:31
groakland
groakland approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@jimhunty jimhunty merged commit 532bc3b into main Apr 26, 2024
4 checks passed
@jimhunty jimhunty deleted the feat/reject-all-gdpr branch April 26, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groakland groakland groakland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimhunty @groakland