Update comments on build number calculation

guardian · Sep 14, 2023 · e37026a · e37026a
1 parent 9fdc232
commit e37026a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/android-beta.yml b/.github/workflows/android-beta.yml
@@ -34,8 +34,7 @@ jobs:
         echo -e "\n\n${{ secrets.ANDROID_GRADLE_PROPERTIES }}" >> projects/Mallard/android/gradle.properties
         echo "${{ secrets.ANDROID_KEYSTORE_BASE64 }}" | base64 --decode > projects/Mallard/android/app/editions-release-2023.keystore
 
-    # For legacy reason we are adding last version code pre-team city (14001358) from Play Store
-    # We are adding 894 so that beta build number is higher than production build number
+    # We add ~900 to the github run number to syncronise it with the last beta build number from TeamCity
     - name: set build number
       run: |
         echo "BUILD_NUMBER=$(($GITHUB_RUN_NUMBER + 894))" >> "$GITHUB_ENV"

diff --git a/.github/workflows/android-release.yml b/.github/workflows/android-release.yml
@@ -34,8 +34,7 @@ jobs:
         echo -e "\n\n${{ secrets.ANDROID_GRADLE_PROPERTIES }}" >> projects/Mallard/android/gradle.properties
         echo "${{ secrets.ANDROID_KEYSTORE_BASE64 }}" | base64 --decode > projects/Mallard/android/app/editions-release-2023.keystore
 
-    # For legacy reason we are adding last version code pre-team city (14001358) from Play Store
-    # We are adding 60 because that was the last build number to run in TeamCity
+    # We add 50 to the github run number to syncronise it with the last release build number from TeamCity
     - name: set build number
       run: |
         echo "BUILD_NUMBER=$(($GITHUB_RUN_NUMBER + 50))" >> "$GITHUB_ENV"