Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove network fronts banner ads ab test #9047

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Remove network fronts banner ads ab test #9047

merged 3 commits into from
Oct 19, 2023

Conversation

domlander
Copy link
Contributor

@domlander domlander commented Oct 6, 2023 •
edited
Loading

What does this change?

  • Removes the fronts-banner ads AB test. The test has ended.
  • Adds a class to the top container of the fronts-banner ad slot.
  • Incorporated code style recommendations from this PR

Why?

  • Delete no longer needed code. Free up test buckets for new tests
  • The top container of the fronts-banner ad slot needs to be collapsed when collapsing the ad, therefore it needs a classname so that it can be found easily in the DOM.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Size Change: +9 B (0%)

Total Size: 1.44 MB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/1076.web.********************.js 3.08 kB 0 B
dotcom-rendering/dist/1134.web.legacy.********************.js 4.27 kB 0 B
dotcom-rendering/dist/1135.web.legacy.********************.js 3.21 kB 0 B
dotcom-rendering/dist/1149.web.********************.js 2.92 kB 0 B
dotcom-rendering/dist/1226.web.********************.js 3.63 kB 0 B
dotcom-rendering/dist/1244.web.********************.js 865 B 0 B
dotcom-rendering/dist/1244.web.legacy.********************.js 870 B 0 B
dotcom-rendering/dist/1282.web.legacy.********************.js 4.21 kB 0 B
dotcom-rendering/dist/1291.web.legacy.********************.js 4.5 kB 0 B
dotcom-rendering/dist/1294.web.********************.js 5.36 kB 0 B
dotcom-rendering/dist/1383.web.legacy.********************.js 5.08 kB 0 B
dotcom-rendering/dist/1406.web.********************.js 5.09 kB 0 B
dotcom-rendering/dist/1418.web.********************.js 10.1 kB 0 B
dotcom-rendering/dist/1438.web.********************.js 3.19 kB 0 B
dotcom-rendering/dist/1465.web.********************.js 3.32 kB 0 B
dotcom-rendering/dist/1486.web.********************.js 744 B 0 B
dotcom-rendering/dist/1486.web.legacy.********************.js 749 B 0 B
dotcom-rendering/dist/1659.web.********************.js 520 B 0 B
dotcom-rendering/dist/1817.web.legacy.********************.js 4.37 kB 0 B
dotcom-rendering/dist/182.web.legacy.********************.js 11.6 kB 0 B
dotcom-rendering/dist/1840.web.legacy.********************.js 3.76 kB 0 B
dotcom-rendering/dist/1848.web.********************.js 644 B 0 B
dotcom-rendering/dist/1848.web.legacy.********************.js 649 B 0 B
dotcom-rendering/dist/1973.web.legacy.********************.js 4.88 kB 0 B
dotcom-rendering/dist/1987.web.********************.js 3.12 kB 0 B
dotcom-rendering/dist/1997.web.********************.js 744 B 0 B
dotcom-rendering/dist/1997.web.legacy.********************.js 749 B 0 B
dotcom-rendering/dist/2038.web.********************.js 4.79 kB 0 B
dotcom-rendering/dist/2071.web.********************.js 745 B 0 B
dotcom-rendering/dist/2071.web.legacy.********************.js 750 B 0 B
dotcom-rendering/dist/21.web.********************.js 758 B 0 B
dotcom-rendering/dist/21.web.legacy.********************.js 763 B 0 B
dotcom-rendering/dist/2113.web.********************.js 29.6 kB 0 B
dotcom-rendering/dist/2126.web.********************.js 884 B 0 B
dotcom-rendering/dist/2126.web.legacy.********************.js 887 B 0 B
dotcom-rendering/dist/2131.web.legacy.********************.js 444 B 0 B
dotcom-rendering/dist/2133.web.********************.js 4.46 kB 0 B
dotcom-rendering/dist/2201.web.********************.js 778 B 0 B
dotcom-rendering/dist/2201.web.legacy.********************.js 779 B 0 B
dotcom-rendering/dist/2228.web.********************.js 899 B 0 B
dotcom-rendering/dist/2228.web.legacy.********************.js 903 B 0 B
dotcom-rendering/dist/2240.web.legacy.********************.js 3.24 kB 0 B
dotcom-rendering/dist/2299.web.legacy.********************.js 8.45 kB 0 B
dotcom-rendering/dist/2339.web.********************.js 778 B 0 B
dotcom-rendering/dist/2339.web.legacy.********************.js 780 B 0 B
dotcom-rendering/dist/2351.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/2401.web.legacy.********************.js 4.05 kB 0 B
dotcom-rendering/dist/2467.web.********************.js 2.08 kB 0 B
dotcom-rendering/dist/2494.web.********************.js 774 B 0 B
dotcom-rendering/dist/2494.web.legacy.********************.js 782 B 0 B
dotcom-rendering/dist/2499.web.legacy.********************.js 2.26 kB 0 B
dotcom-rendering/dist/2546.web.********************.js 3.72 kB 0 B
dotcom-rendering/dist/275.web.********************.js 697 B 0 B
dotcom-rendering/dist/275.web.legacy.********************.js 702 B 0 B
dotcom-rendering/dist/2860.web.legacy.********************.js 7.98 kB 0 B
dotcom-rendering/dist/3024.web.********************.js 621 B 0 B
dotcom-rendering/dist/3024.web.legacy.********************.js 626 B 0 B
dotcom-rendering/dist/3123.web.legacy.********************.js 4.37 kB 0 B
dotcom-rendering/dist/3146.web.********************.js 6.53 kB 0 B
dotcom-rendering/dist/3200.web.legacy.********************.js 4.94 kB 0 B
dotcom-rendering/dist/3358.web.********************.js 637 B 0 B
dotcom-rendering/dist/3358.web.legacy.********************.js 642 B 0 B
dotcom-rendering/dist/3549.web.********************.js 21.3 kB 0 B
dotcom-rendering/dist/3549.web.legacy.********************.js 21.3 kB 0 B
dotcom-rendering/dist/356.web.********************.js 826 B 0 B
dotcom-rendering/dist/356.web.legacy.********************.js 832 B 0 B
dotcom-rendering/dist/3612.web.legacy.********************.js 4.4 kB 0 B
dotcom-rendering/dist/3653.web.********************.js 12.6 kB 0 B
dotcom-rendering/dist/3653.web.legacy.********************.js 4.13 kB 0 B
dotcom-rendering/dist/3960.web.********************.js 619 B 0 B
dotcom-rendering/dist/3960.web.legacy.********************.js 624 B 0 B
dotcom-rendering/dist/3968.web.********************.js 3.79 kB 0 B
dotcom-rendering/dist/4113.web.********************.js 757 B 0 B
dotcom-rendering/dist/4113.web.legacy.********************.js 762 B 0 B
dotcom-rendering/dist/4164.web.legacy.********************.js 600 B 0 B
dotcom-rendering/dist/4246.web.legacy.********************.js 5.72 kB 0 B
dotcom-rendering/dist/4303.web.legacy.********************.js 6.14 kB 0 B
dotcom-rendering/dist/4306.web.********************.js 6.38 kB 0 B
dotcom-rendering/dist/4430.web.legacy.********************.js 3.21 kB 0 B
dotcom-rendering/dist/4591.web.********************.js 405 B 0 B
dotcom-rendering/dist/4593.web.********************.js 1.73 kB 0 B
dotcom-rendering/dist/4734.web.********************.js 759 B 0 B
dotcom-rendering/dist/4734.web.legacy.********************.js 763 B 0 B
dotcom-rendering/dist/480.web.********************.js 524 B 0 B
dotcom-rendering/dist/4895.web.legacy.********************.js 3.69 kB 0 B
dotcom-rendering/dist/4896.web.********************.js 2.17 kB 0 B
dotcom-rendering/dist/4935.web.legacy.********************.js 2.86 kB 0 B
dotcom-rendering/dist/4998.web.legacy.********************.js 4.09 kB 0 B
dotcom-rendering/dist/5021.web.********************.js 963 B 0 B
dotcom-rendering/dist/5021.web.legacy.********************.js 969 B 0 B
dotcom-rendering/dist/5071.web.********************.js 941 B 0 B
dotcom-rendering/dist/5071.web.legacy.********************.js 946 B 0 B
dotcom-rendering/dist/5210.web.********************.js 305 B 0 B
dotcom-rendering/dist/5211.web.********************.js 2.92 kB 0 B
dotcom-rendering/dist/5225.web.********************.js 6.67 kB 0 B
dotcom-rendering/dist/5384.web.********************.js 5.52 kB 0 B
dotcom-rendering/dist/5474.web.********************.js 620 B 0 B
dotcom-rendering/dist/5474.web.legacy.********************.js 625 B 0 B
dotcom-rendering/dist/5615.web.legacy.********************.js 3.69 kB 0 B
dotcom-rendering/dist/5974.web.********************.js 742 B 0 B
dotcom-rendering/dist/5974.web.legacy.********************.js 747 B 0 B
dotcom-rendering/dist/6118.web.********************.js 682 B 0 B
dotcom-rendering/dist/6118.web.legacy.********************.js 687 B 0 B
dotcom-rendering/dist/6126.web.********************.js 2.23 kB 0 B
dotcom-rendering/dist/6389.web.legacy.********************.js 4.59 kB 0 B
dotcom-rendering/dist/640.web.********************.js 711 B 0 B
dotcom-rendering/dist/640.web.legacy.********************.js 716 B 0 B
dotcom-rendering/dist/6437.web.********************.js 867 B 0 B
dotcom-rendering/dist/6437.web.legacy.********************.js 872 B 0 B
dotcom-rendering/dist/6534.web.********************.js 575 B 0 B
dotcom-rendering/dist/6534.web.legacy.********************.js 580 B 0 B
dotcom-rendering/dist/6541.web.********************.js 811 B 0 B
dotcom-rendering/dist/6541.web.legacy.********************.js 817 B 0 B
dotcom-rendering/dist/657.web.********************.js 2.46 kB 0 B
dotcom-rendering/dist/6623.web.********************.js 3.65 kB 0 B
dotcom-rendering/dist/6980.web.legacy.********************.js 2.86 kB 0 B
dotcom-rendering/dist/700.web.legacy.********************.js 3.67 kB 0 B
dotcom-rendering/dist/7133.web.********************.js 699 B 0 B
dotcom-rendering/dist/7133.web.legacy.********************.js 704 B 0 B
dotcom-rendering/dist/7149.web.legacy.********************.js 31.5 kB 0 B
dotcom-rendering/dist/7305.web.********************.js 886 B 0 B
dotcom-rendering/dist/7305.web.legacy.********************.js 892 B 0 B
dotcom-rendering/dist/7401.web.********************.js 689 B 0 B
dotcom-rendering/dist/7401.web.legacy.********************.js 694 B 0 B
dotcom-rendering/dist/7480.web.legacy.********************.js 1.09 kB 0 B
dotcom-rendering/dist/7569.web.********************.js 4.89 kB 0 B
dotcom-rendering/dist/7688.web.********************.js 814 B 0 B
dotcom-rendering/dist/7688.web.legacy.********************.js 819 B 0 B
dotcom-rendering/dist/7831.web.legacy.********************.js 4.37 kB 0 B
dotcom-rendering/dist/786.web.********************.js 477 B 0 B
dotcom-rendering/dist/786.web.legacy.********************.js 482 B 0 B
dotcom-rendering/dist/7874.web.legacy.********************.js 4.08 kB 0 B
dotcom-rendering/dist/8085.web.********************.js 2.59 kB 0 B
dotcom-rendering/dist/8085.web.legacy.********************.js 2.6 kB 0 B
dotcom-rendering/dist/8112.web.********************.js 3.37 kB 0 B
dotcom-rendering/dist/8165.web.********************.js 926 B 0 B
dotcom-rendering/dist/8165.web.legacy.********************.js 931 B 0 B
dotcom-rendering/dist/8170.web.********************.js 490 B 0 B
dotcom-rendering/dist/8170.web.legacy.********************.js 495 B 0 B
dotcom-rendering/dist/818.web.********************.js 2.85 kB 0 B
dotcom-rendering/dist/8268.web.********************.js 5.71 kB 0 B
dotcom-rendering/dist/8341.web.legacy.********************.js 5.12 kB 0 B
dotcom-rendering/dist/8395.web.********************.js 4.97 kB 0 B
dotcom-rendering/dist/8411.web.legacy.********************.js 5.7 kB 0 B
dotcom-rendering/dist/8447.web.********************.js 963 B 0 B
dotcom-rendering/dist/8447.web.legacy.********************.js 969 B 0 B
dotcom-rendering/dist/8505.web.********************.js 556 B 0 B
dotcom-rendering/dist/8505.web.legacy.********************.js 561 B 0 B
dotcom-rendering/dist/8537.web.legacy.********************.js 5.35 kB 0 B
dotcom-rendering/dist/8555.web.********************.js 690 B 0 B
dotcom-rendering/dist/8555.web.legacy.********************.js 695 B 0 B
dotcom-rendering/dist/8622.web.********************.js 858 B 0 B
dotcom-rendering/dist/8622.web.legacy.********************.js 863 B 0 B
dotcom-rendering/dist/8638.web.********************.js 831 B 0 B
dotcom-rendering/dist/8638.web.legacy.********************.js 839 B 0 B
dotcom-rendering/dist/8732.web.legacy.********************.js 3.77 kB 0 B
dotcom-rendering/dist/8739.web.legacy.********************.js 5.39 kB 0 B
dotcom-rendering/dist/8783.web.legacy.********************.js 11.2 kB 0 B
dotcom-rendering/dist/8950.web.legacy.********************.js 3.64 kB 0 B
dotcom-rendering/dist/8978.web.legacy.********************.js 4.83 kB 0 B
dotcom-rendering/dist/9065.web.legacy.********************.js 6.12 kB 0 B
dotcom-rendering/dist/911.web.legacy.********************.js 1.18 kB 0 B
dotcom-rendering/dist/9154.web.********************.js 3.87 kB 0 B
dotcom-rendering/dist/9422.web.********************.js 615 B 0 B
dotcom-rendering/dist/9490.web.********************.js 825 B 0 B
dotcom-rendering/dist/9490.web.legacy.********************.js 831 B 0 B
dotcom-rendering/dist/9568.web.********************.js 5.37 kB 0 B
dotcom-rendering/dist/9714.web.legacy.********************.js 5.75 kB 0 B
dotcom-rendering/dist/9724.web.********************.js 5.02 kB 0 B
dotcom-rendering/dist/9839.web.legacy.********************.js 1.08 kB 0 B
dotcom-rendering/dist/AdPortals-importable.web.********************.js 3.46 kB 0 B
dotcom-rendering/dist/AdPortals-importable.web.legacy.********************.js 4.19 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.web.********************.js 413 B 0 B
dotcom-rendering/dist/AlreadyVisited-importable.web.legacy.********************.js 417 B 0 B
dotcom-rendering/dist/AppEmailSignUp-importable.web.********************.js 7.13 kB 0 B
dotcom-rendering/dist/AppEmailSignUp-importable.web.legacy.********************.js 6.73 kB 0 B
dotcom-rendering/dist/AppsEpic-importable.web.********************.js 3.91 kB 0 B
dotcom-rendering/dist/AppsEpic-importable.web.legacy.********************.js 5.6 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.web.********************.js 2.54 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.web.legacy.********************.js 3.43 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.web.********************.js 2.73 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.web.legacy.********************.js 5 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.web.********************.js 3.27 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.web.legacy.********************.js 3.12 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.********************.js 4.86 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.web.legacy.********************.js 5.65 kB 0 B
dotcom-rendering/dist/Branding-importable.web.********************.js 2.2 kB 0 B
dotcom-rendering/dist/Branding-importable.web.legacy.********************.js 1.97 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.web.********************.js 36.9 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.web.legacy.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.web.********************.js 5.47 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.web.legacy.********************.js 6.13 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.web.********************.js 6.47 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.web.legacy.********************.js 6.81 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.********************.js 5.82 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.web.legacy.********************.js 5.11 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.web.********************.js 2.69 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.web.legacy.********************.js 3.11 kB 0 B
dotcom-rendering/dist/Carousel-importable.web.********************.js 7.56 kB 0 B
dotcom-rendering/dist/Carousel-importable.web.legacy.********************.js 2.69 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.web.********************.js 5.6 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.web.legacy.********************.js 4.82 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.web.********************.js 500 B 0 B
dotcom-rendering/dist/ChartAtom-importable.web.legacy.********************.js 412 B 0 B
dotcom-rendering/dist/CommentCount-importable.web.********************.js 2.85 kB 0 B
dotcom-rendering/dist/CommentCount-importable.web.legacy.********************.js 3.29 kB 0 B
dotcom-rendering/dist/DiscussionContainer-importable.web.********************.js 23.9 kB 0 B
dotcom-rendering/dist/DiscussionContainer-importable.web.legacy.********************.js 21.4 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.web.********************.js 3.72 kB 0 B
dotcom-rendering/dist/DiscussionMeta-importable.web.legacy.********************.js 3.76 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.web.********************.js 2.73 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.web.legacy.********************.js 4.58 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.web.********************.js 3.27 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.web.legacy.********************.js 5 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.web.********************.js 1.91 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.web.legacy.********************.js 1.95 kB 0 B
dotcom-rendering/dist/EuropeLandingModal-importable.web.********************.js 7.36 kB 0 B
dotcom-rendering/dist/EuropeLandingModal-importable.web.legacy.********************.js 7.07 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.web.********************.js 2.5 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.web.legacy.********************.js 2.38 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.********************.js 3.31 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.web.legacy.********************.js 2.82 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.web.********************.js 508 B 0 B
dotcom-rendering/dist/FocusStyles-importable.web.legacy.********************.js 618 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.web.********************.js 3.58 kB 0 B
dotcom-rendering/dist/FollowWrapper-importable.web.legacy.********************.js 860 B 0 B
dotcom-rendering/dist/FooterLabel-importable.web.********************.js 344 B 0 B
dotcom-rendering/dist/FooterLabel-importable.web.legacy.********************.js 375 B 0 B
dotcom-rendering/dist/frameworks.web.********************.js 20.8 kB 0 B
dotcom-rendering/dist/frameworks.web.legacy.********************.js 20.8 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.web.********************.js 3.26 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.web.legacy.********************.js 3.18 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.web.********************.js 12.5 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.web.legacy.********************.js 7.23 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.web.********************.js 355 B 0 B
dotcom-rendering/dist/GetMatchStats-importable.web.legacy.********************.js 1.36 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.web.********************.js 2.31 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.web.legacy.********************.js 2.23 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.web.********************.js 13.4 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.web.legacy.********************.js 12.5 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.web.********************.js 9 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.web.legacy.********************.js 10.8 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.web.********************.js 761 B 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.web.legacy.********************.js 809 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.web.********************.js 10.8 kB 0 B
dotcom-rendering/dist/HeaderTopBar-importable.web.legacy.********************.js 10.7 kB 0 B
dotcom-rendering/dist/index.web.********************.js 37.6 kB 0 B
dotcom-rendering/dist/index.web.legacy.********************.js 44.4 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.web.********************.js 2.81 kB 0 B
dotcom-rendering/dist/InstagramBlockComponent-importable.web.legacy.********************.js 5.22 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.web.********************.js 5.75 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.web.legacy.********************.js 4.35 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.********************.js 3.79 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.web.legacy.********************.js 4.07 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.web.********************.js 4.14 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.web.legacy.********************.js 3.41 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.web.********************.js 2.78 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.web.legacy.********************.js 2.56 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.********************.js 3.52 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.web.legacy.********************.js 3.73 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.web.********************.js 967 B 0 B
dotcom-rendering/dist/LatestLinks-importable.web.legacy.********************.js 1.46 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.web.********************.js 423 B 0 B
dotcom-rendering/dist/LightboxHash-importable.web.legacy.********************.js 433 B 0 B
dotcom-rendering/dist/LightboxJavascript-importable.web.********************.js 4.39 kB 0 B
dotcom-rendering/dist/LightboxJavascript-importable.web.legacy.********************.js 6.05 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.web.********************.js 4.94 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.web.legacy.********************.js 5.07 kB 0 B
dotcom-rendering/dist/Liveness-importable.web.********************.js 3.34 kB 0 B
dotcom-rendering/dist/Liveness-importable.web.legacy.********************.js 7.86 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.********************.js 4.94 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.web.legacy.********************.js 5.45 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.********************.js 5.33 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.web.legacy.********************.js 3.01 kB 0 B
dotcom-rendering/dist/Metrics-importable.web.********************.js 2.39 kB 0 B
dotcom-rendering/dist/Metrics-importable.web.legacy.********************.js 2.61 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.web.********************.js 5.38 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.web.legacy.********************.js 2.53 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.web.********************.js 7.7 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.web.legacy.********************.js 1.96 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.web.********************.js 3.69 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.web.legacy.********************.js 2.71 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.web.********************.js 4.17 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.web.legacy.********************.js 4.07 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.web.********************.js 3.65 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.web.legacy.********************.js 3.9 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.web.********************.js 520 B 0 B
dotcom-rendering/dist/ProfileAtom-importable.web.legacy.********************.js 554 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.web.********************.js 782 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.web.legacy.********************.js 830 B 0 B
dotcom-rendering/dist/PulsingDot-importable.web.********************.js 745 B 0 B
dotcom-rendering/dist/PulsingDot-importable.web.legacy.********************.js 731 B 0 B
dotcom-rendering/dist/QandaAtom-importable.web.********************.js 516 B 0 B
dotcom-rendering/dist/QandaAtom-importable.web.legacy.********************.js 550 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.web.********************.js 460 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.web.legacy.********************.js 477 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.web.********************.js 3.02 kB 0 B
dotcom-rendering/dist/readerRevenueDevUtils.web.legacy.********************.js 3.3 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.web.********************.js 4.86 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.web.legacy.********************.js 5.06 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.web.********************.js 3.18 kB 0 B
dotcom-rendering/dist/RecipeMultiplier-importable.web.legacy.********************.js 5.68 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.web.********************.js 1.92 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.web.legacy.********************.js 1.98 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.web.********************.js 5.97 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.web.legacy.********************.js 4.06 kB 0 B
dotcom-rendering/dist/SecureSignupIframe-importable.web.********************.js 4.89 kB 0 B
dotcom-rendering/dist/SecureSignupIframe-importable.web.legacy.********************.js 4.25 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.web.********************.js 4.38 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.web.legacy.********************.js 7.07 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.web.********************.js 1.98 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.web.legacy.********************.js 2.93 kB 0 B
dotcom-rendering/dist/sentry.web.********************.js 771 B 0 B
dotcom-rendering/dist/sentry.web.legacy.********************.js 768 B 0 B
dotcom-rendering/dist/SetABTests-importable.web.********************.js 4.49 kB 0 B
dotcom-rendering/dist/SetABTests-importable.web.legacy.********************.js 4.8 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.web.********************.js 513 B 0 B
dotcom-rendering/dist/SetAdTargeting-importable.web.legacy.********************.js 523 B 0 B
dotcom-rendering/dist/shimport.web.********************.js 2.78 kB 0 B
dotcom-rendering/dist/shimport.web.legacy.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.web.********************.js 636 B 0 B
dotcom-rendering/dist/ShowHideContainers-importable.web.legacy.********************.js 1.21 kB 0 B
dotcom-rendering/dist/ShowMore-importable.web.********************.js 5.61 kB 0 B
dotcom-rendering/dist/ShowMore-importable.web.legacy.********************.js 5.05 kB 0 B
dotcom-rendering/dist/SignInGateMain.web.********************.js 3.82 kB 0 B
dotcom-rendering/dist/SignInGateMain.web.legacy.********************.js 2.59 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.********************.js 4.88 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.web.legacy.********************.js 3.54 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.web.********************.js 5.55 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.web.legacy.********************.js 5.94 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.web.********************.js 6.27 kB +9 B (0%)
dotcom-rendering/dist/SlotBodyEnd-importable.web.legacy.********************.js 6.04 kB 0 B
dotcom-rendering/dist/Snow-importable.web.********************.js 3.02 kB 0 B
dotcom-rendering/dist/Snow-importable.web.legacy.********************.js 3.33 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.web.********************.js 5.18 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.web.legacy.********************.js 2.93 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.web.********************.js 5.69 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.web.legacy.********************.js 6.52 kB 0 B
dotcom-rendering/dist/SubNav-importable.web.********************.js 2.36 kB 0 B
dotcom-rendering/dist/SubNav-importable.web.legacy.********************.js 2.07 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.web.********************.js 4.97 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.web.legacy.********************.js 5.17 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.web.********************.js 2.78 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.web.legacy.********************.js 2.55 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.web.********************.js 1.19 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.web.legacy.********************.js 1.04 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.web.********************.js 1.01 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.web.legacy.********************.js 791 B 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.********************.js 2.82 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.web.legacy.********************.js 5.23 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.********************.js 5.35 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.web.legacy.********************.js 3.02 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.web.********************.js 2.67 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.web.legacy.********************.js 4.45 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.web.********************.js 5.42 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.web.legacy.********************.js 4.9 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.web.********************.js 3.67 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.web.legacy.********************.js 4.06 kB 0 B

compressed-size-action

@domlander domlander force-pushed the doml/remove-network-fronts-banner-test branch from 22433b8 to 604c660 Compare October 6, 2023 13:50
@domlander domlander marked this pull request as ready for review October 6, 2023 14:10
@domlander domlander requested a review from a team as a code owner October 6, 2023 14:10
DanielCliftonGuardian
DanielCliftonGuardian reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are more occurrences of isInNetworkFrontsBannerTest that should be removed or renamed

@domlander
Copy link
Contributor Author

I think there are more occurrences of isInNetworkFrontsBannerTest that should be removed or renamed

Thanks Daniel, I'll make sure to remove the other references. This PR is on hold for now as some folks are using the 0% test to do some of their own testing, so I'll add the "do not merge" label for now, then pick this up again later.

@domlander domlander force-pushed the doml/remove-network-fronts-banner-test branch from 604c660 to 810ae84 Compare October 19, 2023 15:52
@domlander domlander force-pushed the doml/remove-network-fronts-banner-test branch from 810ae84 to 23b84bf Compare October 19, 2023 15:57
@domlander domlander added the run_chromatic Runs chromatic when label is applied label Oct 19, 2023
@domlander domlander merged commit c591fca into main Oct 19, 2023
@domlander domlander deleted the doml/remove-network-fronts-banner-test branch October 19, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielCliftonGuardian DanielCliftonGuardian DanielCliftonGuardian left review comments

@arelra arelra arelra approved these changes

Assignees
No one assigned
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domlander @arelra @DanielCliftonGuardian