Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stretched IMA video container #9036

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Fix stretched IMA video container #9036

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e191b12
Add CSS for YouTube IMA ad container
Jakeii Oct 5, 2023
ff0a88d
add stylelint ignore
Jakeii Oct 5, 2023
648ccb3
move styles to the player component
Jakeii Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions dotcom-rendering/src/components/YoutubeAtom/YoutubeAtomPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { css } from '@emotion/react';
import type { Participations } from '@guardian/ab-core';
import type { AdsConfig } from '@guardian/commercial';
import {
Expand Down Expand Up @@ -81,6 +82,27 @@ type PlayerListeners = Array<PlayerListener<PlayerListenerName>>;
*/
type ExtractEventType<T> = T extends YT.PlayerEventHandler<infer X> ? X : never;

const imaAdContainerStyles = css`
/*
The IMA script gives the following styles to the ad container element:
width: [pixel value equal to the youtube iframe's width]
height: [pixel value equal to the youtube iframe's height]
position: relative;
display: block;
We need to override these styles to make sure that the ad container overlays
the youtube player exactly and to avoid a player-sized white space underneath the ad.
*/
/* stylelint-disable-next-line declaration-no-important -- we need this to override inline styles added by youtube */
width: 100% !important;
/* stylelint-disable-next-line declaration-no-important -- we need this to override inline styles added by youtube */
height: 100% !important;
/* stylelint-disable-next-line declaration-no-important -- we need this to override inline styles added by youtube */
position: absolute !important;
top: 0;
left: 0;
display: none;
`;

const dispatchCustomPlayEvent = (uniqueId: string) => {
document.dispatchEvent(
new CustomEvent(customPlayEventName, {
Expand Down Expand Up @@ -630,6 +652,7 @@ export const YoutubeAtomPlayer = ({
<div
id={imaAdContainerId}
data-atom-type="ima-ad-container"
css={imaAdContainerStyles}
></div>
)}
</>
Expand Down