Migrate YoutubeAtom to DCR #8836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCorr
force-pushed
the
ash/YoutubeAtom
branch
from
5194ea4 to
ca3ef3e
Compare
|
Size Change: 0 B 🆕 Total Size: 0 B |
AshCorr
force-pushed
the
ash/YoutubeAtom
branch
from
af643bc to
9330793
Compare
arelra
approved these changes
Sep 26, 2023
arelra
force-pushed
the
ash/YoutubeAtom
branch
from
47cff26 to
0eb50f9
Compare
arelra
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Migrates all of the youtube atom code from CSNX to DCR.
I've tried to keep changes fairly minimal but needed to change a few things to get this to work correctly in DCR / comply with DCR linting.
articlePillarcolours, this was deprecated a while back. We use decidePalette in DCR to do this now.weightingwhich is completely ignored by YoutubeAtomwindow.YTas undefined in DCR. I'm not sure how this isn't a problem in atoms-rendering, but for some reason Typescript thinks window.YT will never be undefined, which is completely untrue.Why?
This allows us to better support the YoutubeAtom and use eventually our image optimiser to improve user experience
Screenshots