KeyEvents in LiveLayout
#3595
Merged
KeyEvents in LiveLayout
#3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlloyd
requested review from
DavidLawes,
jlieb10,
lucymonie,
nicl,
nitro-marky and
OllysCoding
as code owners
|
Size Change: +5.04 kB (0%) Total Size: 3.1 MB
ℹ️ View Unchanged
|
Co-authored-by: Olly <olly.namey@theguardian.com>
Co-authored-by: OllysCoding
Co-authored by @OllysCoding
Co-Authored-By: Olly <9575458+OllysCoding@users.noreply.github.com>
Co-Authored-By: Olly <9575458+OllysCoding@users.noreply.github.com>
idrise
reviewed
Nov 5, 2021
dotcom-rendering/src/web/components/KeyEventsContainer.test.tsx
Outdated
Show resolved
Hide resolved
oliverlloyd
commented
Nov 8, 2021
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "extends": "./tsconfig.json", | |||
| "compilerOptions": { | |||
| "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */ | |||
There was a problem hiding this comment.
oliverlloyd
commented
Nov 8, 2021
| @@ -94,7 +94,7 @@ const buildPayload = async ({ | |||
| optedOutOfArticleCount, | |||
| modulesVersion: MODULES_VERSION, | |||
| sectionId, | |||
| tagIds: tags.map(tag => tag.id), | |||
| tagIds: tags.map((tag) => tag.id), | |||
There was a problem hiding this comment.
Prettier hangover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR adds the
KeyEventscomponent to the DCRLiveLayoutfile so it renders on live and dead blogs.isolatedModules?We set this to true in the jest config for DCR because we were getting errors when importing code from common rendering into jest.
See this issue with ts-jest