-
Notifications
You must be signed in to change notification settings - Fork 30
Add MoreGalleries component with a story #14538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+505
−11
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
367a603
Add MoreGalleries component with a story
marjisound 550e771
Merge branch 'main' into add-more-galleries-component
marjisound 7d92d1b
add new prop to TrailText to ensure it is not hidden on smaller break…
marjisound 044a757
replace px with space
marjisound 356ebb6
some cleaning up
marjisound 35dba38
Merge branch 'main' into add-more-galleries-component
marjisound ac6dc74
Refactor TrailText comp to remove un-necessary display none until tablet
marjisound 0b65da0
Merge branch 'main' into add-more-galleries-component
marjisound ce987db
Address review comments
marjisound 73cd910
decoupling a flexible splash card with an onward container splash card
marjisound 2365930
Merge branch 'main' into add-more-galleries-component
marjisound d0d6f40
Merge branch 'main' into add-more-galleries-component
marjisound File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
206 changes: 206 additions & 0 deletions
206
dotcom-rendering/src/components/MoreGalleries.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,206 @@ | ||
import type { Meta, StoryObj } from '@storybook/react'; | ||
import { ArticleDesign, ArticleDisplay, Pillar } from '../lib/articleFormat'; | ||
import { getDataLinkNameCard } from '../lib/getDataLinkName'; | ||
import { MoreGalleries as MoreGalleriesComponent } from './MoreGalleries'; | ||
|
||
const meta = { | ||
title: 'Components/MoreGalleries', | ||
component: MoreGalleriesComponent, | ||
} satisfies Meta<typeof MoreGalleriesComponent>; | ||
|
||
export default meta; | ||
|
||
type Story = StoryObj<typeof meta>; | ||
|
||
export const MoreGalleries = { | ||
args: { | ||
absoluteServerTimes: false, | ||
discussionApiUrl: 'https://discussion.theguardian.com/discussion-api', | ||
headingLink: 'https://www.theguardian.com/inpictures/all', | ||
trails: [ | ||
{ | ||
url: 'https://www.theguardian.com/environment/gallery/2025/aug/22/week-in-wildlife-a-clumsy-fox-swinging-orangutang-and-rescued-jaguarundi-cub', | ||
linkText: | ||
'Week in wildlife: a clumsy fox, a swinging orangutan and a rescued jaguarundi cub', | ||
showByline: false, | ||
byline: 'Pejman Faratin', | ||
image: { | ||
src: 'https://media.guim.co.uk/a81e974ffee6c8c88fa280c2d02eaf5dc2af863e/151_292_1020_816/master/1020.jpg', | ||
altText: '', | ||
}, | ||
format: { | ||
theme: Pillar.News, | ||
design: ArticleDesign.Gallery, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
webPublicationDate: '2025-08-22T06:00:25.000Z', | ||
headline: | ||
'Week in wildlife: a clumsy fox, a swinging orangutan and a rescued jaguarundi cub', | ||
shortUrl: 'https://www.theguardian.com/p/x32n89', | ||
discussion: { | ||
isCommentable: false, | ||
isClosedForComments: true, | ||
discussionId: '/p/x32n89', | ||
}, | ||
dataLinkName: getDataLinkNameCard( | ||
{ | ||
theme: Pillar.News, | ||
design: ArticleDesign.Gallery, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
'0', | ||
0, | ||
), | ||
trailText: | ||
'Guinness World Records is looking back at the extraordinary feats achieved since its inception - as well as unveiling 70 whacky and unclaimed records ', | ||
kickerText: 'Politics', | ||
mainMedia: { type: 'Gallery', count: '6' }, | ||
}, | ||
{ | ||
url: 'https://www.theguardian.com/money/gallery/2025/aug/22/characterful-cottages-for-sale-in-england-in-pictures', | ||
linkText: | ||
'Characterful cottages for sale in England – in pictures', | ||
showByline: false, | ||
byline: 'Anna White', | ||
image: { | ||
src: 'https://media.guim.co.uk/58cd9356e6d68e8efa6028162bb959f9798307d5/515_0_5000_4000/master/5000.jpg', | ||
altText: '', | ||
}, | ||
format: { | ||
design: ArticleDesign.Gallery, | ||
theme: Pillar.Lifestyle, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
webPublicationDate: '2025-08-22T06:00:24.000Z', | ||
headline: | ||
'Characterful cottages for sale in England – in pictures', | ||
shortUrl: 'https://www.theguardian.com/p/x32gqj', | ||
discussion: { | ||
isCommentable: false, | ||
isClosedForComments: true, | ||
discussionId: '/p/x32gqj', | ||
}, | ||
dataLinkName: getDataLinkNameCard( | ||
{ | ||
design: ArticleDesign.Gallery, | ||
theme: Pillar.Lifestyle, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
'0', | ||
1, | ||
), | ||
trailText: | ||
'Picked from a record 60,636 entries, the first images from the Natural History Museum’s wildlife photographer of the year competition have been released. The photographs, which range from a lion facing down a cobra to magnified mould spores, show the diversity, beauty and complexity of the natural world and humanity’s relationship with it', | ||
mainMedia: { type: 'Gallery', count: '6' }, | ||
}, | ||
{ | ||
url: 'https://www.theguardian.com/news/gallery/2025/aug/22/sunsets-aid-parachutes-and-giant-pandas-photos-of-the-day-friday', | ||
linkText: | ||
'Sunsets, aid parachutes and giant pandas: photos of the day – Friday ', | ||
showByline: false, | ||
byline: 'Eithne Staunton', | ||
image: { | ||
src: 'https://media.guim.co.uk/4ce0b080206fe9b65b976c1acf219d81072cc814/0_0_2113_1690/master/2113.png', | ||
altText: '', | ||
}, | ||
format: { | ||
design: ArticleDesign.Gallery, | ||
theme: Pillar.News, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
webPublicationDate: '2025-08-22T12:49:42.000Z', | ||
headline: | ||
'Sunsets, aid parachutes and giant pandas: photos of the day – Friday ', | ||
shortUrl: 'https://www.theguardian.com/p/x3359z', | ||
discussion: { | ||
isCommentable: false, | ||
isClosedForComments: true, | ||
discussionId: '/p/x3359z', | ||
}, | ||
dataLinkName: getDataLinkNameCard( | ||
{ | ||
design: ArticleDesign.Gallery, | ||
theme: Pillar.News, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
'0', | ||
2, | ||
), | ||
trailText: | ||
'From the mock-Tudor fad of the 1920s to drivers refuelling on a roundabout, each era produces its own distinctive petrol stations – as photographer Philip Butler discovered', | ||
mainMedia: { type: 'Gallery', count: '6' }, | ||
}, | ||
{ | ||
url: 'https://www.theguardian.com/fashion/gallery/2025/aug/22/what-to-wear-to-notting-hill-carnival', | ||
linkText: 'On parade: what to wear to Notting Hill carnival', | ||
showByline: false, | ||
byline: 'Melanie Wilkinson', | ||
image: { | ||
src: 'https://media.guim.co.uk/49a9656cd10c4f64f8bdd54380afb915c7a3648b/207_0_1500_1200/master/1500.jpg', | ||
altText: '', | ||
}, | ||
format: { | ||
design: ArticleDesign.Gallery, | ||
theme: Pillar.Lifestyle, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
webPublicationDate: '2025-08-22T05:00:23.000Z', | ||
headline: 'On parade: what to wear to Notting Hill carnival', | ||
shortUrl: 'https://www.theguardian.com/p/x32mte', | ||
discussion: { | ||
isCommentable: false, | ||
isClosedForComments: true, | ||
discussionId: '/p/x32mte', | ||
}, | ||
dataLinkName: getDataLinkNameCard( | ||
{ | ||
design: ArticleDesign.Gallery, | ||
theme: Pillar.Lifestyle, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
'0', | ||
1, | ||
), | ||
trailText: | ||
'The Guardian’s picture editors select photographs from around the world', | ||
mainMedia: { type: 'Gallery', count: '6' }, | ||
}, | ||
{ | ||
url: 'https://www.theguardian.com/artanddesign/gallery/2025/aug/21/psychedelic-rock-glass-mountain-michael-lundgren', | ||
linkText: | ||
'Psychedelic rock! Formations that mess with your mind – in pictures ', | ||
showByline: false, | ||
image: { | ||
src: 'https://media.guim.co.uk/2810af61b2d2d2d5f71ec01e56e6555e0a6d4635/55_0_2813_2250/master/2813.jpg', | ||
altText: '', | ||
}, | ||
format: { | ||
design: ArticleDesign.Gallery, | ||
theme: Pillar.Culture, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
webPublicationDate: '2025-08-21T06:01:01.000Z', | ||
headline: | ||
'Psychedelic rock! Formations that mess with your mind – in pictures ', | ||
shortUrl: 'https://www.theguardian.com/p/x2p663', | ||
discussion: { | ||
isCommentable: false, | ||
isClosedForComments: true, | ||
discussionId: '/p/x2p663', | ||
}, | ||
dataLinkName: getDataLinkNameCard( | ||
{ | ||
design: ArticleDesign.Gallery, | ||
theme: Pillar.Culture, | ||
display: ArticleDisplay.Standard, | ||
}, | ||
'0', | ||
1, | ||
), | ||
trailText: | ||
'Politicians and their partners put on their best show at this year’s Midwinter Ball, an annual dinner hosted by the Federal Parliamentary Press Gallery in Canberra', | ||
mainMedia: { type: 'Gallery', count: '6' }, | ||
}, | ||
], | ||
}, | ||
} satisfies Story; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should rename this field or use a seperate one here. I'm not sure we should be coupling a flexible splash card with an onwards container splash, unless they are truely the same card. If they are then perhaps renaming to something more generic (ie removing the flexible part would be preferable).
Does the onwards "splash" card share the same characteristics as a flexible splash card?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out @abeddow91
You are right, it seems the characteristics of a flexible splash card is different from an onward splash card.
The
isFlexSplash
is primarily used to deal with positioning the sub links. But what's important in an onward splash card is that it needs to have the trail text while the non-splash cards do not have trail text.I created a new prop
isOnwardSplash
for this in here 73cd910