feat(YoutubeAtom): player requires ad targeting #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 61657a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The YoutubeAtomPlayer can only be initialised once, and we require the ad targeting to be present before initialisation. Co-authored-by: Ravi <7014230+arelra@users.noreply.github.com>
mxdvl
force-pushed
the
mxdvl/ensure-ad-targeting-is-set
branch
from
3241f4b to
61657a6
Compare
DanielCliftonGuardian
approved these changes
Jun 30, 2023
ob6160
approved these changes
Jun 30, 2023
This was referenced Jun 30, 2023
arelra
added a commit
that referenced
this pull request
Jul 10, 2023
## What are you changing? Pass valid ad targeting to `YoutubeAtom` stories so the player is able to load. ## Background Since guardian/dotcom-rendering#8095 ad targeting will be set async on the client so it could be undefined initially and then defined in subsequent render passes. However the player requires ad targeting before it initialises and makes the request to YouTube so we block the player until ad targeting is defined as implemented in #675.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
YoutubeAtomPlayercan only be initialised once, and we require the ad targeting to be present before initialisation.Why?
undefinedfor the first render.