Update typescript setup #1542
Merged
Update typescript setup #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ed9b893 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
github-actions
bot
added
📦 npm
mxdvl
approved these changes
Jun 13, 2024
SiAdcock
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
tsccommands to all apps/packagests-jestdoesn't need them anyway)"include": ["."]for"include": ["**/*"](just for clarity, because it's TS's actual default)Two fixes also need new releases:
@emotion/reactto fix (an issue with ambient type defs in it's deps)(ChangeArraytoReadonlyArrayin CSS type declarations emotion-js/emotion#3141)libsindev-kitchenWhy?
The recent move to using esbuild in rollup (#1385) means that types are not checked as part of the build process.
Even when they were, files which were included in TS projects but were not included in builds (e.g. configs, stories etc) were never checked.