Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test content-api-model preview version for content-entity #415

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Mar 27, 2024

We are bumping preview version of content-api-model that as got content-entity's latest release version to test - https://github.com/guardian/content-entity/actions/runs/8439281276
The other PR for reference: guardian/content-api-models#246

Co-authored: @rtyley

How to test

Make a preview release and test in any of client consuming this library, we are going to try it in apple-news.

How can we measure success?

Application should run fine and should not have no conflicts in version or errors in the test.

@Divs-B Divs-B requested a review from a team as a code owner March 27, 2024 10:00
@gu-scala-library-release
Copy link
Contributor

@Divs-B has published a preview version of this PR with release workflow run #47, based on commit fa502f8:

26.0.0-PREVIEW.dbtest-content-api-model-preview-version.2024-03-27T1001.fa502f80

Want to make another preview release?

Click 'Run workflow' in the GitHub UI, specifying the db/test-content-api-model-preview-version branch, or use the GitHub CLI command:

gh workflow run release.yml --ref db/test-content-api-model-preview-version

Want to make a full release after this PR is merged?

Click 'Run workflow' in the GitHub UI, leaving the branch as the default, or use the GitHub CLI command:

gh workflow run release.yml

@Divs-B
Copy link
Contributor Author

Divs-B commented Apr 12, 2024

Now we are bumping content-api-model's latest 24.0.0 release version which contains both content-entity and content-atom latest release.

@Divs-B Divs-B force-pushed the db/test-content-api-model-preview-version branch 2 times, most recently from 0dc77d2 to 3f8c26b Compare April 19, 2024 16:30
@Divs-B Divs-B force-pushed the db/test-content-api-model-preview-version branch from 3f8c26b to e90e3ce Compare April 19, 2024 17:11
Copy link

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit e90e3ce. ± Comparison against base commit 2a09247.

Copy link
Member

@rtyley rtyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What's the PR where this was tried in Apple News?

@Divs-B
Copy link
Contributor Author

Divs-B commented Apr 23, 2024

Looks good! What's the PR where this was tried in Apple News?

Ah good question, I have checked and tested by running locally onapple-news at the time when I was tesing all preview releases, means preview release on this PR work and including other libraries that are required in apple new like firehose and facia-client too, The apple-news was worked as expected so didnt try raising PR.
I think if its okay, I will do now with these Production releases and will attach here the output from it to confirm.

@Divs-B Divs-B merged commit 9adfba4 into main Apr 23, 2024
2 checks passed
@Divs-B
Copy link
Contributor Author

Divs-B commented Apr 23, 2024

This release is verified and tested.
Checked in facia-client: guardian/facia-scala-client#312 and at the end tested in one of client using all that is apple-news:https://github.com/guardian/apple-news/pull/331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants