feat: Implement GuScheduledEcsTask pattern #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philmcmahon
force-pushed
the
jw-scheduled-ecs-task-attempt
branch
2 times, most recently
from
19e9c21 to
21c9905
Compare
akash1810
reviewed
Sep 13, 2021
There was a problem hiding this comment.
A few questions added.
Similar to #761, I'd be interested to see how these commits get parsed (#761 (comment)) and improve the docs afterwards.
philmcmahon
force-pushed
the
jw-scheduled-ecs-task-attempt
branch
from
991851b to
cb6a6fb
Compare
|
@adamnfish we had a stab at some better tests - dropped the simple snapshot one and instead tested for a couple of things that we care about. It could be more thorough but I think this is a good start 8e8b3a9 |
akash1810
reviewed
Sep 14, 2021
akash1810
reviewed
Sep 14, 2021
philmcmahon
force-pushed
the
jw-scheduled-ecs-task-attempt
branch
from
25b2e7f to
e970025
Compare
… schedule is being used
… schedule is being used
philmcmahon
force-pushed
the
jw-scheduled-ecs-task-attempt
branch
from
e970025 to
f794458
Compare
|
Looks like the build is happy now. I've attempted to shorten the commit history a bit too and added the relevant |
akash1810
approved these changes
Sep 14, 2021
|
🎉 This PR is included in version 25.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds a new pattern to the cdk library - a fargate task that is run on a schedule using a step function.
The purpose of the step function is to make alarming/alerting easier if the task times out or fails.
I've written quite a bit of documentation within the code files explaining the different props of this task but shout if something doesn't make sense.
See here (private repo so shout if you need access) for some example code using this pattern. That branch is destined for mergification fairly soon.
Hopefully it makes sense for this to live here, otherwise I can dump it back in the lurch project
Does this change require changes to existing projects or CDK CLI?
No
Does this change require changes to the library documentation?
I have added documentation in comments to the task code - maybe I need to add it somewhere else?
How to test
This is being used already in the lurch CODE and soon to be PROD environments. I've added a basic test file copied from the GuScheduledLambda tests.
How can we measure success?
A team other than investigations uses this
Have we considered potential risks?
Is this a generic enough need? In theory yes - anyone wanting to do a scheduled thing that takes longer than the 15 minute lambda time out.