chore: Remove linting from integration-test project #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.23.2 of `eslint-plugin-import` prefers to `import` statements above `import type`. We do not have a lockfile for the `integration-test` project because: > Ignore package-lock.json to avoid the following error when reinstalling dependencies: > npm ERR! notarget No matching version found for eslint-plugin-custom-rules@1.0.0. > This is because we're installing @guardian/cdk from file, which is in turn installing eslint-plugin-custom-rules from file. Combined this with the version of `eslint-plugin-import` is defined with `^`, linting is non-deterministic* and we only saw an import order linting error locally after removing `node_modules`. There are a couple of ways to improve this: - Work out how to use a lockfile in the integration-test - Remove linting and hope the other dependencies using `^` versions are OK This change removes linting, with the justification that: - This project is never consumed by anyone - This project doesn't run anywhere - This project doesn't get updated too often - Understanding the original lockfile issues is a time sink See: - import-js/eslint-plugin-import#2021 - #564 * Well, the entire build of integration-test is non-deterministic!
jacobwinch
approved these changes
May 19, 2021
akash1810
added a commit
that referenced
this pull request
May 19, 2021
We previously had issues with lockfiles in CI for the integration-test project. This caused a few issues and led to the changes in #569. This change reverts those commits and adds a lockfile. That is, I'm not sure what the previous issues were, but they don't seem to exist anymore and we can use lockfiles in CI and gain deterministic builds.
akash1810
added a commit
that referenced
this pull request
May 19, 2021
We previously had issues with lockfiles in CI for the `integration-test` project. This caused a few issues and led to the changes in #569. This change reverts those commits and adds a lockfile. That is, I'm not sure what the previous issues were, but they don't seem to exist anymore and we can use lockfiles in CI and gain deterministic builds.
|
🎉 This PR is included in version 15.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #564.
What does this change?
Version 2.23.2 of
eslint-plugin-importprefers toimportstatementsabove
import type.We do not have a lockfile for the
integration-testproject because:Combined this with the version of
eslint-plugin-importis defined with^, linting is non-deterministic* and we only saw an import order linting error locally after removingnode_modules.There are a couple of ways to improve this:
^versions are OKThis change removes linting, with the justification that:
See:
order: support type imports import-js/eslint-plugin-import#2021*Well, the entire build of integration-test is non-deterministic!
Does this change require changes to existing projects or CDK CLI?
No.
Does this change require changes to the library documentation?
No.
How to test
CI should pass.
How can we measure success?
CI passes on all branches; Dependabot branches are currently failing.
Have we considered potential risks?
n/a