fix: Update GuApplicationListener with revised logicalId logic
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #364 we placed the logic of overriding a construct's logicalId into a single place. In this change, we're updating the `GuApplicationListener` construct to adopt the new logic. As of #418 it's as simple as using the `GuStatefulMigratableConstruct` mixin! The logicalId logic currently in `GuApplicationListener` is very complicated with multiple paths to overriding the logicalId. This is massively simplified, as evidenced in the updated tests.
|
|
||
| export class GuApplicationListener extends ApplicationListener { | ||
| export class GuApplicationListener extends GuStatefulMigratableConstruct(ApplicationListener) { |
There was a problem hiding this comment.
Did not know this is a thing, nice!
stephengeller
approved these changes
Apr 12, 2021
|
🎉 This PR is included in version 8.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
In #364 we placed the logic of overriding a construct's logicalId into a single place.
In this change, we're updating the
GuApplicationListenerconstruct to adopt the new logic. As of #418 it's as simple as using theGuStatefulMigratableConstructmixin!The logicalId logic currently in
GuApplicationListeneris very complicated with multiple paths to overriding the logicalId.This is massively simplified, as evidenced in the updated tests.
This is the first in a series of PRs to adopt the new logic. Hopefully this multi PR approach is better than the previous monster PR (#400)!
Does this change require changes to existing projects or CDK CLI?
Possibly.
The overriding logic in
GuApplicationListenerhas changed. If stacks are making use of the current (broken?) logic, they will need to be attended to.How to test
See tests?
How can we measure success?
A simpler, DRYer, code base?
Have we considered potential risks?
As noted above, the path to update to the next version of the library might require a bit of attention.