GuKCLPolicy: Fix DynamoDB permissions on new KCL v3 tables
#2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57ed86d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rtyley
force-pushed
the
fix-dynamodb-permissions-for-GuKCLPolicy
branch
4 times, most recently
from
96477f6 to
6ed3232
Compare
In PR #2578 I failed to give the `UpdateItem` & `DeleteItem` permissions on these new KCL v3 tables: * worker metrics: https://docs.aws.amazon.com/streams/latest/dev/kcl-dynamoDB.html#kcl-worker-metrics-table * coordinator state: https://docs.aws.amazon.com/streams/latest/dev/kcl-dynamoDB.html#kcl-coordinator-state-table ...the permissions were correctly granted on the 'lease' table, so existing code, based on KCL v2, _worked_ (as seen in guardian/apple-news#426 (comment)), but as soon as the code was updated to KCL v3, errors were seen: guardian/apple-news#398 (comment) This fix correctly grants the `UpdateItem` & `DeleteItem` permissions to all 3 tables. For reference, the full list of permissions are at: https://docs.aws.amazon.com/streams/latest/dev/kcl-iam-permissions.html
rtyley
force-pushed
the
fix-dynamodb-permissions-for-GuKCLPolicy
branch
from
6ed3232 to
57ed86d
Compare
akash1810
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #2578 I failed to grant the
UpdateItem&DeleteItempermissions on these two new KCL v3 tables:-WorkerMetricStats-CoordinatorState...the permissions were correctly granted on the existing 'lease' table, so existing code based on KCL v2, worked, but as soon as the code was updated to KCL v3, errors started:
This fix correctly grants the
UpdateItem&DeleteItempermissions to all 3 tables.UpdateTableis now the only permission granted solely on to the 'lease' table.For reference, the full list of IAM permissions for KCL v3 are at: