fix(GitHubOidcProvider): Ensure AWS::IAM::OIDCProvider resource is tagged
#2531
Conversation
…tagged Apply the standard `Stack`, `Stage`, `App` and `gu:repo` tags to the `AWS::IAM::OIDCProvider` resource. This was previously absent as we're creating `AWS::IAM::OIDCProvider` via a level 1 construct; AWS CDK only automatically tags level 2 constructs.
🦋 Changeset detectedLatest commit: 60639fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Not sure if this is operator error, but when I tried to deploy the cloudformation from guardian/content-api-firehose-client@f5e2be8 (which was using GU-CDK 61.0.1), I got this error:
...as I was creating the cloudformation stack, I manually added these tags to it:
...I guess maybe I shouldn't do that? I shouldn't put my own tags on the cloudformation stack itself? |
Ah yes, if I don't apply my own |
|
Confirming this works as expected in 
|
What does this change?
Apply the standard
Stack,Stage,Appandgu:repotags to theAWS::IAM::OIDCProviderresource created by theGitHubOidcProviderconstruct.This was previously absent as we're creating
AWS::IAM::OIDCProvidervia a level 1 construct; AWS CDK only automatically tags level 2 constructs.How to test
See the added unit test. The test uses the
hasGuTaggedResourceassertion helper.How can we measure success?
Tagging resources makes it easier to identify their origin, and to allocate costs, etc.
Have we considered potential risks?
N/A.
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩