fix: Publish new version reverting 59.5.3 #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 08e6833 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
AshCorr
commented
Oct 18, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@guardian/cdk", | |||
| "description": "Generic Guardian flavoured AWS CDK components", | |||
| "version": "59.5.2", | |||
| "version": "59.5.3", | |||
There was a problem hiding this comment.
Don't let it try to publish to 59.5.3 when it generates a release.
AshCorr
commented
Oct 18, 2024
Comment on lines
+3
to
+6
| ## 59.5.3 | ||
|
|
||
| **DO NOT USE**: Published by mistake. | ||
|
|
There was a problem hiding this comment.
Add a changelog entry for 59.5.3 to let people know why it exists and to not use it.
akash1810
reviewed
Oct 21, 2024
.changeset/tall-eagles-heal.md
Outdated
Comment on lines
7
to
10
| - a334ea9: bump @types/node from 22.7.4 to 22.7.5 | ||
| - 504fe94: bump @changesets/cli from 2.27.8 to 2.27.9 | ||
| - 5a5498d: bump @types/node from 22.7.0 to 22.7.4 | ||
| - 7dbd8ac: bump @types/node from 22.5.5 to 22.7.0 |
There was a problem hiding this comment.
These are all dev dependencies; I'm surprised to see them causing a version change.
There was a problem hiding this comment.
Ah yea, good point! Removed!
AshCorr
force-pushed
the
ash/unpublish-59.5.3
branch
from
2da8d36 to
08e6833
Compare
1 task
akash1810
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
v59.5.3 was published by mistake whilst trying to publish a beta build from the
betabranch.Instead of unpublishing 59.5.3 which would leave a hole in our NPM versions as per https://docs.npmjs.com/policies/unpublish instead publish a new 59.5.4 version which reverts the changes that were made in 59.5.3.
Also include the latest version bumps.