test: add simplified tag assertion #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jacobwinch
commented
Apr 17, 2024
| }, | ||
| ], | ||
| GuTemplate.fromStack(stack).hasResourceWithTag("AWS::RDS::DBInstance", { | ||
| Key: "devx-backup-enabled", |
There was a problem hiding this comment.
I've manually checked that setting the wrong tag value (or mistyping the key) here causes the test to fail.
2 tasks
akash1810
approved these changes
Apr 23, 2024
jacobwinch
force-pushed
the
jw-tag-helper
branch
from
958f4e5 to
44d1094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a suggestion from #2276 (comment).
I don't think AWS provides a way to do this, so I've added a helper function to combine resource property matching and array matching in order to get this working.
I think this makes the tests added in #2276 easier to follow and hopefully it will make it easier for others to check tag correctness in the future too.