Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update aws-cdk to 2.23.0 #1276

Merged
merged 1 commit into from
May 17, 2022
Merged

chore(deps): Update aws-cdk to 2.23.0 #1276

merged 1 commit into from
May 17, 2022

Conversation

jacobwinch
Copy link
Contributor

Small follow up to #1251.

Whilst working on guardian/amiable#138, I copy & pasted the versions from peer dependencies without thinking about it. This mismatch leads to the following error when running cdk synth:

This CDK CLI is not compatible with the CDK library used by your application. Please upgrade the CLI to the latest version.

This PR should help others to avoid this problem.

@jacobwinch jacobwinch requested a review from a team as a code owner May 17, 2022 08:39
Copy link
Member

@akash1810 akash1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh! Good catch! Looks like it was missed here, suggesting the script broke when we moved to V2?

@jacobwinch jacobwinch merged commit 6299a8a into main May 17, 2022
@jacobwinch jacobwinch deleted the jw-aws-cdk branch May 17, 2022 11:59
@jacobwinch
Copy link
Contributor Author

suggesting the script broke when we moved to V2?

Yes, I think you're right.

The command looks OK:

"update-aws-cdk": "ncu \"aws-cdk-lib\" \"aws-cdk\" \"constructs\" --upgrade --deep --target minor",

My best guess is that it doesn't work correctly because aws-cdk is a peer dependency only:

"aws-cdk": "2.23.0",

Because it's working OK with the integration tests, where it's a devDependency.

@akash1810
Copy link
Member

akash1810 commented May 17, 2022

It looks like ncu does not touch peerDependencies (see raineorshine/npm-check-updates#951). So it seems that asaws-cdk-lib is listed as a dependency and peer dependency in package.json, it's happily updated. Whereas aws-cdk is only listed as a peer dependency, so is left untouched.

A little confusing (as is most dependency management!). Not sure what to do... maybe add aws-cdk as a dev dependency to trick ncu?

@jacobwinch
Copy link
Contributor Author

maybe add aws-cdk as a dev dependency to trick ncu?

Yeah it's a bit of a hack, but I think it's fairly harmless!

@github-actions
Copy link
Contributor

🎉 This PR is included in version 43.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants