feat(asg): Collect all ASG level metrics

Collect all ASG level metrics as standard.
These metrics should come at no extra cost.

See https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-metrics.html.

To collect a subset instead, use the escape hatch mechanism:

```ts
declare const asg: AutoScalingGroup;

const cfnAsg = asg.node.defaultChild as CfnAutoScalingGroup;

cfnAsg.metricsCollection = [
  {
    granularity: "1Minute",
    metrics: [
      // A subset of metrics
    ],
  },
];
```

.changeset/rare-geese-wait.md

@@ -0,0 +1,27 @@
+---
+"@guardian/cdk": minor
+---
+
+feat(asg) Collect all ASG level metrics
+
+This change should have no cost impact:
+
+> Group metrics are available at one-minute granularity at no additional charge, but you must enable them.
+> – https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-metrics.html.
+
+If it does, or if you only want a subset, the escape hatch mechanism can be used:
+
+```ts
+declare const asg: AutoScalingGroup;
+
+const cfnAsg = asg.node.defaultChild as CfnAutoScalingGroup;
+
+cfnAsg.metricsCollection = [
+  {
+    granularity: "1Minute",
+    metrics: [
+      // A subset of metrics
+    ],
+  },
+];
+```

src/constructs/autoscaling/asg.ts

@@ -1,6 +1,6 @@
 import type { Duration } from "aws-cdk-lib";
 import { Tags, Token } from "aws-cdk-lib";
-import { AutoScalingGroup, GroupMetric, GroupMetrics } from "aws-cdk-lib/aws-autoscaling";
+import { AutoScalingGroup, GroupMetrics } from "aws-cdk-lib/aws-autoscaling";
 import type { AutoScalingGroupProps, CfnAutoScalingGroup } from "aws-cdk-lib/aws-autoscaling";
 import { LaunchTemplate, OperatingSystemType } from "aws-cdk-lib/aws-ec2";
 import type { InstanceType, ISecurityGroup, MachineImageConfig, UserData } from "aws-cdk-lib/aws-ec2";
@@ -88,7 +88,7 @@ export class GuAutoScalingGroup extends GuAppAwareConstruct(AutoScalingGroup) {
       imageId = new GuAmiParameter(scope, { app }),
       imageRecipe,
       instanceType,
-      groupMetrics = [new GroupMetrics(GroupMetric.TOTAL_INSTANCES, GroupMetric.IN_SERVICE_INSTANCES)],
+      groupMetrics = [GroupMetrics.all()],
       minimumInstances,
       maximumInstances,
       role = new GuInstanceRole(scope, { app }),

src/patterns/ec2-app/__snapshots__/base.test.ts.snap

@@ -91,10 +91,6 @@ exports[`the GuEC2App pattern can produce a restricted EC2 app locked to specifi
         "MetricsCollection": [
           {
             "Granularity": "1Minute",
-            "Metrics": [
-              "GroupTotalInstances",
-              "GroupInServiceInstances",
-            ],
           },
         ],
         "MinSize": "1",
@@ -1108,10 +1104,6 @@ exports[`the GuEC2App pattern should produce a functional EC2 app with minimal a
         "MetricsCollection": [
           {
             "Granularity": "1Minute",
-            "Metrics": [
-              "GroupTotalInstances",
-              "GroupInServiceInstances",
-            ],
           },
         ],
         "MinSize": "1",