Ignore emacs backup/swap files by default. #546
Conversation
lib/listen/silencer.rb
Outdated
| @@ -34,6 +34,9 @@ class Silencer | |||
| | \.swpx | |||
| | ^4913 | |||
|
|
|||
| # Emacs backup/swap files | |||
| | (?:\.\#.+|\#.+\#) | |||
There was a problem hiding this comment.
I believe these should be anchored per our discussion on the Issue. And \A and \z are the best way to anchor in Ruby so as not to be tripped up by newlines (which are rare in filenames...but possible). So I think this does it:
(?:\A\.\#.|\A\#.+\#\z)
There was a problem hiding this comment.
@ColinDKelley , oh, i add to wrong place, i thought where i insert in regexp is around with a ^...$
for \A, \z, agree with you, but why i can't find those anchor within exists regexp? (only see some ^, $ anchor out of group)
There was a problem hiding this comment.
I'm guessing that those who wrote the earlier code didn't know about the Ruby trap of ^ and $ not working the same as in every other language.
I can also believe the some of the existing patterns weren't anchored at all, even when they should have been.
There was a problem hiding this comment.
okay, so, double confirm, you want me fix those exists regexp anchor, and then add emacs pattern into it, right?
There was a problem hiding this comment.
Yes, two separate commits should make it clear:
- Fix the existing ^ and $ anchors to \A and \z.
- Add your new emacs patterns with \A and \z anchors.
Or if you'd rather keep this PR simple, we can flip the order and I can take care of (2):
- You add your new emacs patterns with ^ and $ anchors.
- [after merging this PR] I fix all the ^ and $ anchors to \A and \z.
There was a problem hiding this comment.
Got it, let me do both of them first anyway.
| @@ -122,7 +122,7 @@ listener.stop # stop both listening to changes and processing them | |||
|
|
|||
| ### Ignore / ignore! | |||
|
|
|||
| `Listen` ignores some directories and extensions by default (See DEFAULT_IGNORED_DIRECTORIES and DEFAULT_IGNORED_EXTENSIONS in Listen::Silencer). | |||
| `Listen` ignores some directories and extensions by default (See DEFAULT_IGNORED_FILES and DEFAULT_IGNORED_EXTENSIONS in Listen::Silencer). | |||
There was a problem hiding this comment.
`Listen` ignores some files and extensions by default (See
| @@ -157,7 +157,7 @@ All the following options can be set through the `Listen.to` after the directory | |||
|
|
|||
| ```ruby | |||
| ignore: [%r{/foo/bar}, /\.pid$/, /\.coffee$/] # Ignore a list of paths | |||
| # default: See DEFAULT_IGNORED_DIRECTORIES and DEFAULT_IGNORED_EXTENSIONS in Listen::Silencer | |||
| # default: See DEFAULT_IGNORED_FILES and DEFAULT_IGNORED_EXTENSIONS in Listen::Silencer | |||
There was a problem hiding this comment.
Thanks for renaming this!
For fix #543