linux driver can abort the enclosing process

[ColinDKelley]

Current State

If :INotify::Notifier.new (or #watch) were to raise Errno::ENOSPC, the linux driver would abort the containing process:

      def _configure(directory, &callback)
        require 'rb-inotify'
        @worker ||= ::INotify::Notifier.new
        @worker.watch(directory.to_s, *options.events, &callback)
      rescue Errno::ENOSPC
        abort(INOTIFY_LIMIT_MESSAGE)
      end

Calling abort from a gem is never appropriate.

Desired State

Errno::ENOSPC should be wrapped by raising a named exception (with ENOSPC as the cause). That will raise out of the public interface start. The calling code in the containing process can then take the appropriate action, by rescuing that specific exception or a catch-all base class.

Steps to Reproduce

I didn't try, but you'd need to run out the count of inotify file descriptors. Then call listener.start. That would cause the containing process to abruptly abort.

[ColinDKelley]

@ioquatix Do you agree that this should be fixed? I've never seen it happen in production...but we'd be appalled if it did. It could cause a total outage of a company's service! Yikes. This feels like a "ticking time bomb".

[ioquatix]

Why was it added in the first place?

[ColinDKelley]

That line hasn't been touched in 7 years: f9e8220

[ColinDKelley]

But it appears to have first been added 8.5 years ago: 5e3053d