Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure icons are added to assets #348

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Ensure icons are added to assets #348

merged 2 commits into from
Dec 17, 2024

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented Dec 17, 2024

Fixes #347

I'm directly merging this into main to avoid yet another PR.

@dkastl dkastl requested a review from sanak December 17, 2024 01:07
sanak
sanak approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkastl Sorry, I missed this issue in PR #343.
I confirmed that main branch has the svg icon and custom icon font issues, and this PR branch solves those issues.
Thanks a lot!

@dkastl dkastl merged commit a6acb0a into main Dec 17, 2024
13 checks passed
@dkastl dkastl deleted the dkastl/issue347 branch December 17, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanak sanak sanak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Font and icon webpack loader issue
2 participants
@dkastl @sanak