-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dry-run #74
Conversation
No concern regarding the new feature. However it's hard to review as the styling changes add a lot of noise. @michaeldmitry can you isolate styling changes and actual feature in separate commits? Also it would be good to know what tool are you using for styling and if there is any special configuration |
126c39e
to
8cc4da9
Compare
@gtsystem separated (as much as possible) formatting and feature changes into 2 commits. BTW, should I bump the version in |
Looks good.
Yes, please |
Done :) |
Fixes #73
Solution
Add a
dry_run
optional argument topatch
,replace
,create
,delete
,delete_collection
forAsyncClient
andClient
that will pass adryRun
query parameter to requests.Additionally, fixed some linting :)
Context
Dry-running a request would be a nice addition (and a lightweight one too!) for users to perform validation calls to their spec changes that are not strictly typed by lightkube (e.g: resources limits and requests are
dict
s and are prone to invalid values like {"CpU": "-100km"})