gio: add spawn_blocking() #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbor
reviewed
Oct 31, 2022
sdroege
reviewed
Nov 1, 2022
|
Looks good to me otherwise |
jf2048
force-pushed
the
task-spawn-blocking
branch
from
f13e733 to
f7deb7d
Compare
sdroege
reviewed
Nov 9, 2022
sdroege
reviewed
Nov 9, 2022
sdroege
reviewed
Nov 9, 2022
sdroege
reviewed
Nov 9, 2022
RealKC
reviewed
Nov 9, 2022
jf2048
force-pushed
the
task-spawn-blocking
branch
2 times, most recently
from
9b62dbc to
0b61fa7
Compare
sdroege
reviewed
Nov 17, 2022
sdroege
reviewed
Nov 17, 2022
|
Looks good to me apart from those minor things now :) That looks like a great usability improvement! |
jf2048
force-pushed
the
task-spawn-blocking
branch
from
0b61fa7 to
04f1ea3
Compare
sdroege
reviewed
Nov 19, 2022
sdroege
reviewed
Nov 19, 2022
sdroege
reviewed
Nov 19, 2022
sdroege
reviewed
Nov 19, 2022
jf2048
force-pushed
the
task-spawn-blocking
branch
2 times, most recently
from
4302dff to
5ad903b
Compare
jf2048
force-pushed
the
task-spawn-blocking
branch
from
5ad903b to
2f2dbd4
Compare
sdroege
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #792
After looking at the equivalent tokio API I noticed we don't install unwind handlers, maybe that is something that should happen?