Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[allow(clippy::should_implement_trait)] if method is named default #1395

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Add #[allow(clippy::should_implement_trait)] if method is named default #1395

merged 1 commit into from
Oct 27, 2022

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez force-pushed the allow-should-implement-trait branch from e0a5e55 to 60c4816 Compare October 26, 2022 20:15
sdroege
sdroege reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sufficient to put it on the function instead of the type? Sure, go ahead

@GuillaumeGomez
Copy link
Member Author

Apparently. :)

@GuillaumeGomez GuillaumeGomez merged commit 818f714 into gtk-rs:master Oct 27, 2022
@GuillaumeGomez GuillaumeGomez deleted the allow-should-implement-trait branch October 27, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege left review comments

@bilelmoussaoui bilelmoussaoui Awaiting requested review from bilelmoussaoui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @sdroege