This repository has been archived by the owner on Jun 8, 2021. It is now read-only.
Add a safe API for user data #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should doc-comments go into https://github.com/gtk-rs/lgpl-docs? Are docs written specifically for Rust bindings also under the LGPL? |
|
If the doc comments come from somewhere under LGPL, then LGPL, otherwise it's MIT and you can leave them where they are. |
sdroege
reviewed
May 13, 2019
| if let Ok(surface) = &result { | ||
| static IMAGE_SURFACE_DATA: crate::UserDataKey<Box<dyn AsMut<[u8]>>> = | ||
| crate::UserDataKey::new(); | ||
| surface.set_user_data(&IMAGE_SURFACE_DATA, Rc::new(data)) |
There was a problem hiding this comment.
Why does this have to be in an Rc?
There was a problem hiding this comment.
Oh I see, because of the getter
|
👍 |
|
Thanks @SimonSapin (especially for the documentation!)! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.