Skip to content

Commit

Permalink
Re-initialize platform dependent netty classes/values at runtime
Browse files Browse the repository at this point in the history
Platform dependent classes should not be initialized at build time to
avoid issues when running the native executable on a different platform.

This patch registers two platform dependent classes for runtime
re-initialization and disables the use of `Unsafe` in netty.
Unfortunately when re-initializing `PlatformDependent0` it fails to
properly setup unsafe accesses resulting in `NullPointerExceptions` when
invoking `putByte`.
Disabling unsafe accesses for netty works around this.

The above changes result in Quarkus native applications to respect
arguments like `-Dio.netty.maxDirectMemory=1024` and
`-XX:MaxDirectMemorySize=1g`.

Fixes quarkusio#17839

(cherry picked from commit ca155ca)
  • Loading branch information
zakkak authored and gsmet committed Feb 15, 2023
1 parent a9ff48d commit 942c54d
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ NativeImageConfigBuildItem build(
String maxOrder = calculateMaxOrder(config.allocatorMaxOrder, minMaxOrderBuildItems, false);

NativeImageConfigBuildItem.Builder builder = NativeImageConfigBuildItem.builder()
//.addNativeImageSystemProperty("io.netty.noUnsafe", "true")
// disable unsafe usage to allow io.netty.internal.PlarformDependent0 to be reinitialized without issues
.addNativeImageSystemProperty("io.netty.noUnsafe", "true")
// Use small chunks to avoid a lot of wasted space. Default is 16mb * arenas (derived from core count)
// Since buffers are cached to threads, the malloc overhead is temporary anyway
.addNativeImageSystemProperty("io.netty.allocator.maxOrder", maxOrder)
Expand All @@ -109,6 +110,9 @@ NativeImageConfigBuildItem build(
.addRuntimeInitializedClass("io.netty.buffer.ByteBufUtil")
// The default channel id uses the process id, it should not be cached in the native image.
.addRuntimeInitializedClass("io.netty.channel.DefaultChannelId")
// Make sure to re-initialize platform dependent classes/values at runtime
.addRuntimeReinitializedClass("io.netty.util.internal.PlatformDependent")
.addRuntimeReinitializedClass("io.netty.util.internal.PlatformDependent0")
.addNativeImageSystemProperty("io.netty.leakDetection.level", "DISABLED");

if (QuarkusClassLoader.isClassPresentAtRuntime("io.netty.handler.codec.http.HttpObjectEncoder")) {
Expand Down

0 comments on commit 942c54d

Please sign in to comment.