Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Input
references toButtonInput
KeyCode
values to prependKey
(e.g.,KeyCode::W
->KeyCode::KeyW
)Cube
andPlane
meshes with their new math primitives as recommended for depreciation reasonsColor
into aStandardMaterial
rather than relying on implicitinto()
AddRollbackCommandExtension
to match new lifetime generics forEntityCommands
EntityMapper
(which is now a trait instead of a type) forRollbackEntityMap
, which will return the provided entity if it is not contained in the mapping. This ensures entities which are not tracked by the rollback map are not modified.HashMap
of theRollbackEntityMap
with anEntityHashMap
, which is an optimised type provided by Bevy.Component
andResource
entity mapper plugins to use the newEntityMapper
implementation provided byRollbackEntityMap
. This removes a significant TODO on their implementations where if a mapping was done over a non-rollback entity, the mapping had to be undone.fmt
andclippy
and ensured clean output.Tests and the synctest example work as expected. I haven't had a chance to verify this against a real multiplayer application, so if anyone has the free time to test this branch out, please do!