Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding release instructions in PR #1488

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat: Adding release instructions in PR #1488

merged 2 commits into from
Dec 12, 2024

Conversation

yhakbar
Copy link
Contributor

@yhakbar yhakbar commented Dec 11, 2024 •
edited
Loading

Description

Fixes #000.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@yhakbar yhakbar requested a review from denis256 as a code owner December 11, 2024 19:20
james03160927
james03160927 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhakbar yhakbar merged commit 1389227 into main Dec 12, 2024
2 of 3 checks passed
@yhakbar yhakbar deleted the feat/adding-release-guidance branch December 12, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhakbar @james03160927