-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack: clean #3871
Stack: clean #3871
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request refactors error handling for the stacks experiment in the stack command by introducing a new function, Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant C as CLI Parser
participant R as RunClean Function
participant OS as Operating System
U->>C: Execute "stack clean" command
C->>R: Call RunClean(opts)
R->>R: Execute checkStackExperiment(opts)
Note right of R: Return error if experiment disabled
R->>OS: Attempt to remove stack directory
OS-->>R: Return success/error status
R-->>C: Return final result
C-->>U: Output command result
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
#### stack clean | ||
|
||
Running `terragrunt stack clean` removes the `.terragrunt-stack` directory, which is generated by the `terragrunt stack generate` | ||
or `terragrunt stack run` commands. This can be useful when you need to reset the stack state or troubleshoot issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or `terragrunt stack run` commands. This can be useful when you need to reset the stack state or troubleshoot issues. | |
or `terragrunt stack run` commands. This can be useful when you need to remove generated configurations or troubleshoot issues. |
Avoid using the term "state" unless you're talking about OpenTofu/Terraform state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/_docs/04_reference/02-cli-options.md (1)
497-501
: Improve clarity by avoiding the term "state".Based on previous feedback, we should avoid using the term "state" unless specifically referring to OpenTofu/Terraform state.
Apply this diff to clarify the purpose:
-Running `terragrunt stack clean` removes the `.terragrunt-stack` directory, which is generated by the `terragrunt stack generate` -or `terragrunt stack run` commands. This can be useful when you need to remove generated configurations or troubleshoot issues. +Running `terragrunt stack clean` removes the `.terragrunt-stack` directory, which is generated by `terragrunt stack generate` +or `terragrunt stack run` commands. This can be useful when you need to remove generated configurations or troubleshoot issues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/_docs/04_reference/02-cli-options.md
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: unessential
- GitHub Check: build-and-test
- GitHub Check: Pull Request has non-contributor approval
🔇 Additional comments (1)
docs/_docs/04_reference/02-cli-options.md (1)
369-496
: Great job on the comprehensive documentation!The
stack output
command documentation is thorough, well-structured, and includes clear examples for all supported formats. The examples effectively demonstrate both basic and advanced usage patterns.
Description
RFC: #3313
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide
Summary by CodeRabbit