Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TGW Route Table to AWS SDK v2 #801

Conversation

sc250024
Copy link
Contributor

@sc250024 sc250024 commented Dec 4, 2024

Description

Fixes #770. These commits are cherry-picked from my other PR here: #800

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Updated transit-gateway-route-table to AWS SDK v2

@sc250024
Copy link
Contributor Author

sc250024 commented Dec 4, 2024

CC @james03160927

@sc250024
Copy link
Contributor Author

sc250024 commented Dec 4, 2024

Results from local testing:

git rev-parse HEAD
c9c6043691a7b966d4216656720dde7efe7e953bgo test -count=1 -parallel=10 -run "TestTransitGatewayRouteTables*" ./...
?   	github.com/gruntwork-io/cloud-nuke	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/externalcreds	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/logging	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/telemetry	[no test files]
?   	github.com/gruntwork-io/cloud-nuke/v2_migration_report	[no test files]
ok  	github.com/gruntwork-io/cloud-nuke/aws	0.578s [no tests to run]
ok  	github.com/gruntwork-io/cloud-nuke/aws/resources	0.630s
ok  	github.com/gruntwork-io/cloud-nuke/commands	0.903s [no tests to run]
ok  	github.com/gruntwork-io/cloud-nuke/config	1.083s [no tests to run]
ok  	github.com/gruntwork-io/cloud-nuke/report	1.464s [no tests to run]
ok  	github.com/gruntwork-io/cloud-nuke/ui	1.288s [no tests to run]
ok  	github.com/gruntwork-io/cloud-nuke/util	1.660s [no tests to run]

Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
@sc250024 sc250024 force-pushed the chore-migrate-tgw-route-tables-aws-sdk-v2 branch from fbf9595 to c9c6043 Compare December 5, 2024 02:39
@james03160927 james03160927 self-assigned this Dec 5, 2024
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 6b41d02 into gruntwork-io:master Dec 5, 2024
2 checks passed
@sc250024 sc250024 deleted the chore-migrate-tgw-route-tables-aws-sdk-v2 branch December 5, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to AWS SDKv2
2 participants