Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change port launch config, launch template, msk cluster, oidc provider to awsSDKv2 #770 #792

Merged
merged 1 commit into from
Nov 25, 2024
Merged

change port launch config, launch template, msk cluster, oidc provider to awsSDKv2 #770 #792

merged 1 commit into from
Nov 25, 2024

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Nov 19, 2024

Description

Fixes #770 port resources to AWS SDK v2

  • launch config
  • launch template
  • msk cluster
  • oidc provider

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

[x] Updated change port launch config, launch template, msk cluster, oidc provider to AWS SDK v2 #770

Migration Guide

n/a

@wakeful wakeful force-pushed the migrate-to-aws-sdk-v2-part-6 branch from 7f51e5e to 1994efc Compare November 20, 2024 10:37
@wakeful wakeful mentioned this pull request Nov 21, 2024
Closed
5 tasks
@wakeful wakeful force-pushed the migrate-to-aws-sdk-v2-part-6 branch from 1994efc to e3c1d25 Compare November 25, 2024 08:34
james03160927
james03160927 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james03160927 james03160927 merged commit 2f6f96c into gruntwork-io:master Nov 25, 2024
2 checks passed
@wakeful wakeful deleted the migrate-to-aws-sdk-v2-part-6 branch November 26, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@arsci arsci Awaiting requested review from arsci arsci is a code owner

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to AWS SDKv2
2 participants
@wakeful @james03160927