Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSK nuking fix #652

Merged
merged 1 commit into from
Mar 18, 2024
Merged

MSK nuking fix #652

merged 1 commit into from
Mar 18, 2024

Conversation

autero1
Copy link
Contributor

@autero1 autero1 commented Mar 17, 2024

Description

  • Fix MSK nuking
  • Add MSK in recurring nuke jobs

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Fix MSK nuking

@james03160927
Copy link
Contributor

LGTM

@autero1 autero1 merged commit 152f823 into master Mar 18, 2024
3 checks passed
@autero1 autero1 deleted the feat/msk branch March 18, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants