Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cloud-nuke Circle Golang Version to 1.21 #636

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

james03160927
Copy link
Contributor

Description

Fixes #000.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james03160927 james03160927 force-pushed the latest_golang branch 9 times, most recently from ea143c2 to 529d5c9 Compare February 13, 2024 22:52
@james03160927 james03160927 changed the title Use the latest golang image Bump Cloud-nuke Circle Golang Version to 1.21 Feb 14, 2024
Copy link

@ryehowell ryehowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI looks good to you!

@james03160927 james03160927 merged commit c65b4c8 into master Feb 14, 2024
3 checks passed
@james03160927 james03160927 deleted the latest_golang branch February 14, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants