Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nukable check + nukable check implementation for transit gateway #635

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

james03160927
Copy link
Contributor

@james03160927 james03160927 commented Jan 25, 2024

Description

Fixes #000..

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james03160927 james03160927 force-pushed the check_nukable branch 4 times, most recently from 61e6363 to df74230 Compare January 29, 2024 23:50
@denis256
Copy link
Member

denis256 commented Feb 7, 2024

CICD building fails with

Cannot find circleci/go@1.21 in the orb registry. Check that the namespace, orb name and version are correct.

Most probably should be something like 1.21.6
https://circleci.com/developer/images/image/cimg/go#image-tags

@james03160927 james03160927 merged commit 2f78eb9 into master Feb 9, 2024
2 of 3 checks passed
@james03160927 james03160927 deleted the check_nukable branch February 9, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aw transit-gateway-attachment should check nukable before describing
2 participants