Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support backup-vault nuke #488

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Support backup-vault nuke #488

merged 1 commit into from
Jul 5, 2023

Conversation

james03160927
Copy link
Contributor

Description

Fixes #446.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

updated [Support backup-vault nuke]

Migration Guide

Copy link
Contributor

@oredavids oredavids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left one minor suggestion.

return "backup-vault"
}

// ResourceIdentifiers - The instance ids of the ec2 instances
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ResourceIdentifiers - The instance ids of the ec2 instances
// ResourceIdentifiers - The names of the backup vaults

@james03160927 james03160927 merged commit 02adaac into master Jul 5, 2023
@james03160927 james03160927 deleted the issues/446_backup_vault branch July 5, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup vault is n't supported by cloud nuke
2 participants