Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create .npmignore #124

Closed
wants to merge 1 commit into from
Closed

Create .npmignore #124

wants to merge 1 commit into from

Conversation

pwmckenna
Copy link

No description provided.

@shama
Copy link
Member

shama commented Nov 30, 2013

Thanks for the PR! Would you mind configuring the files key in the package.json instead? As outlined in this issue: gruntjs/gruntjs.com#65

@pwmckenna pwmckenna mentioned this pull request Nov 30, 2013
Merged
@pwmckenna
Copy link
Author

interesting...the npm docs don't seem to indicate which should be used. Is the theory that .npmignore should only be used to catch things like .env or other local configuration?

@shama
Copy link
Member

shama commented Nov 30, 2013

.npmignore will ignore files where the files key will include files. Since we're including less files than we're ignoring, the inclusion way make more sense.

@shama
Copy link
Member

shama commented Nov 30, 2013

Closing in favor of #125.

@shama shama closed this Nov 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwmckenna @shama