Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #108 side effect #131

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stephanebachelier
Copy link
Contributor

See #108 (comment) about #108 being backward incompatible with AMD namespace with dots.

@lostthetrail
Copy link

Cloned from comment in: #108

@stephanebachelier
Ah drat. I noticed something that might still be problematic.

If you have a function that returns a dot based namespace, you will still have the issue.

var myVar = 'FooVar';

namespace: function() {
    return 'Foo.Templates.' + myVar;
}

@lostthetrail
Copy link

@stephanebachelier No updates?

@stephanebachelier
Copy link
Contributor Author

@lostthetrail sorry did not had the time before to complete my patch. Will push an update tomorrow.

@lostthetrail
Copy link

@stephanebachelier Any updates?

@stephanebachelier
Copy link
Contributor Author

@lostthetrail I had issue to rebase my work on master.
Regarding a function which return dots, is the namespace function always returning the same value ?

Are you using the filename variable like this:

          namespace: function(filename) {
            return 'JST.templates.' + filename;
          }

@lostthetrail
Copy link

Not exactly your example.

grunt.config(['handlebars', namespace], {
   options: {
       namespace: function() {
           return 'MyBiz.template.' + namespace
       }
   },
   files: [...]
});

@stephanebachelier
Copy link
Contributor Author

@lostthetrail thank for you answer, I will add a test with your example.

@lostthetrail
Copy link

@stephanebachelier Did this ever happen?

Base automatically changed from master to main March 22, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants