Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase bios_size to 1MB #630

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Increase bios_size to 1MB #630

wants to merge 9 commits into from

Conversation

ABelliqueux
Copy link
Contributor

:p

@wheremyfoodat
Copy link
Collaborator

wheremyfoodat commented Oct 4, 2021

@ABelliqueux
Uhhh you'd need to adjust the memory handlers, recompiler etc to work with 1MB BIOSes too. And you'd also want to detect a 1MB BIOS before treating a BIOS as such.

@nicolasnoble
Copy link
Member

There are lots of other places this would need to be updated unfortunately :)

(this doesn't pass basic tests because of a buffer overflow).

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #630 (af21852) into main (1d81a0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #630   +/-   ##
=======================================
  Coverage   25.76%   25.76%           
=======================================
  Files         189      189           
  Lines       56225    56225           
=======================================
  Hits        14484    14484           
  Misses      41741    41741           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d81a0a...af21852. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants