Added additional parameters to support synced folder and ip-adress #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some additional configuration parameters , shared_folder_host and shared_folder_guest for adding a synced folder and priv_net_ip for setting the private network ip-adress. Changed the Vagrantfile accordingly as well.
Script for updating the kernel modules so updated vbguest ad-ons be installed on the box. Code from dotless-de/vagrant-vbguest#141 thread.
|
Interesting stuff in here, but can you make a few changes? I'll make inline comments.. |
| @@ -34,14 +34,24 @@ end | |||
| puts "ml-version=#{@ml_version}" | |||
| puts "nr-hosts=#{@nr_hosts}" | |||
|
|
|||
| @priv_net_ip = ENV['PRIV_NET_IP'] || @properties['PRIV_NET_IP'] || "192.168.33.10" | |||
There was a problem hiding this comment.
I'd prefer no default ip, and use dhcp as default for private network as well.
Set parameters to default. Changed back memory to 2048 Made new parameters optional
|
Added a new commit with changes. Removed the addition to handle kernel update. |
grtjn
added a commit
that referenced
this pull request
Jun 26, 2015
Added additional parameters to support synced folder and ip-adress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some additional configuration parameters , shared_folder_host and
shared_folder_guest for adding a synced folder and priv_net_ip for
setting the private network ip-adress. Changed the Vagrantfile
accordingly as well.
Also added fix for installing updated vbguest ad-ons.